Use unique identifier in test resources

Author: gabedos

smoke_tests/ecs_fargate/all-dd-disabled.tf

@@ -36,7 +36,7 @@ module "dd_task_all_dd_disabled" {
     enabled = false,
   }
 
-  family = "terraform-test-all-dd-disabled"
+  family = "${var.test_prefix}-all-dd-disabled"
   container_definitions = jsonencode([
     {
       name : "dummy-container",

smoke_tests/ecs_fargate/all-dd-inputs.tf

@@ -57,7 +57,7 @@ module "dd_task_all_dd_inputs" {
   }
 
   # Configure Task Definition
-  family = "terraform-test-all-dd-inputs"
+  family = "${var.test_prefix}-all-dd-inputs"
   container_definitions = jsonencode([
     {
       name      = "datadog-dogstatsd-app",

smoke_tests/ecs_fargate/all-ecs-inputs.tf

@@ -32,7 +32,7 @@ resource "aws_efs_access_point" "fs" {
 }
 
 resource "aws_iam_role" "ecs_task_role" {
-  name = "terraform-test-ecs-task-role"
+  name = "${var.test_prefix}-ecs-task-role"
 
   assume_role_policy = jsonencode({
     Version = "2012-10-17"
@@ -49,7 +49,7 @@ resource "aws_iam_role" "ecs_task_role" {
 }
 
 resource "aws_iam_policy" "ecs_task_policy" {
-  name        = "terraform-test-ecs-task-policy"
+  name        = "${var.test_prefix}-ecs-task-policy"
   description = "Policy for ECS task role to access EFS"
   policy = jsonencode({
     Version = "2012-10-17"
@@ -82,7 +82,7 @@ module "dd_task_all_ecs_inputs" {
   dd_site    = var.dd_site
   dd_service = var.dd_service
 
-  family = "terraform-test-all-ecs-inputs"
+  family = "${var.test_prefix}-all-ecs-inputs"
   container_definitions = jsonencode([
     {
       name      = "datadog-dummy-app",

smoke_tests/ecs_fargate/all-null.tf

@@ -13,7 +13,7 @@ module "dd_task_all_null" {
 
   # Required values
   dd_api_key = var.dd_api_key
-  family     = "terraform-test-all-null"
+  family     = "${var.test_prefix}-all-null"
   container_definitions = jsonencode([
     {
       name : "dummy-container",

smoke_tests/ecs_fargate/all-windows.tf

@@ -24,7 +24,7 @@ module "dd_task_all_windows" {
     enabled = true
   }
 
-  family = "terraform-test-all-windows"
+  family = "${var.test_prefix}-all-windows"
   container_definitions = jsonencode([
     {
       name      = "datadog-dogstatsd-app",

smoke_tests/ecs_fargate/apm-dsd-tcp-udp.tf

@@ -28,7 +28,7 @@ module "dd_task_apm_dsd_tcp_udp" {
     socket_enabled = false,
   }
 
-  family = "terraform-test-apm-dsd-tcp-udp"
+  family = "${var.test_prefix}-apm-dsd-tcp-udp"
   container_definitions = jsonencode([
     {
       name      = "datadog-dogstatsd-app",

smoke_tests/ecs_fargate/cws-only.tf

@@ -35,7 +35,7 @@ module "dd_task_cws_only" {
     enabled = true,
   }
 
-  family = "terraform-test-cws-only"
+  family = "${var.test_prefix}-cws-only"
   container_definitions = jsonencode([
     {
       name      = "datadog-cws-app",

smoke_tests/ecs_fargate/logging-only.tf

@@ -34,7 +34,7 @@ module "dd_task_logging_only" {
     }
   }
 
-  family                = "terraform-test-logging-only"
+  family                = "${var.test_prefix}-logging-only"
   container_definitions = jsonencode([])
 
   requires_compatibilities = ["FARGATE"]

smoke_tests/ecs_fargate/variables.tf

@@ -18,4 +18,10 @@ variable "dd_site" {
   description = "Datadog Site"
   type        = string
   default     = "datadoghq.com"
+}
+
+variable "test_prefix" {
+  description = "The ECS task family name prefix"
+  type        = string
+  default     = "terraform-test"
 }

tests/main_test.go

@@ -7,6 +7,7 @@ package test
 
 import (
 	"log"
+	"os"
 	"testing"
 
 	"github.com/gruntwork-io/terratest/modules/terraform"
@@ -28,15 +29,23 @@ func TestECSFargateSuite(t *testing.T) {
 func (s *ECSFargateSuite) SetupSuite() {
 	log.Println("Setting up test suite resources...")
 
+	// All resources must be prefixed with terraform-test
+	testPrefix := "terraform-test"
+	ciJobID := os.Getenv("CI_JOB_ID")
+	if ciJobID != "" {
+		testPrefix = testPrefix + "-" + ciJobID
+	}
+
 	// Define the Terraform options for the suite
 	s.terraformOptions = &terraform.Options{
 		// Path to the smoke_tests directory
 		TerraformDir: "../smoke_tests/ecs_fargate",
 		// Variables to pass to the Terraform module
 		Vars: map[string]interface{}{
-			"dd_api_key": "test-api-key",
-			"dd_service": "test-service",
-			"dd_site":    "datadoghq.com",
+			"dd_api_key":  "test-api-key",
+			"dd_service":  "test-service",
+			"dd_site":     "datadoghq.com",
+			"test_prefix": testPrefix,
 		},
 		NoColor: true,
 	}