Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: KeyError: 'signals' #11825

Open
Omar-Bishtawi opened this issue Dec 22, 2024 · 1 comment
Open

[BUG]: KeyError: 'signals' #11825

Omar-Bishtawi opened this issue Dec 22, 2024 · 1 comment
Assignees
Labels
bug Dynamic Instrumentation Dynamic Instrumentation/Live Debugger

Comments

@Omar-Bishtawi
Copy link

Tracer Version(s)

ddtrace==2.17.3

Python Version(s)

Python 3.11.6

Pip Version(s)

24.3.1

Bug Report

sometimes without a clear pattern, or clear reproduction steps . we get the following error:

Traceback (most recent call last):
  File "/var/python/venv/lib64/python3.11/site-packages/ddtrace/debugging/_debugger.py", line 266, in __return__
    self._close_signals(retval=value)
  File "/var/python/venv/lib64/python3.11/site-packages/ddtrace/debugging/_debugger.py", line 238, in _close_signals
    signals = cast(Deque[Signal], self.get("signals"))
                                  ^^^^^^^^^^^^^^^^^^^
  File "/var/python/venv/lib64/python3.11/site-packages/ddtrace/internal/wrapping/context.py", line 286, in get
    return self._storage_stack.get()[-1][key]
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
KeyError: 'signals'

It doesn't cause any behavioral issues on the application or in APM.

we started to notice this issue more when we enabled Dynamic instrumentation (might be correlated and might not)

Reproduction Code

No response

Error Logs

No response

Libraries in Use

No response

Operating System

No response

@mabdinur mabdinur added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jan 2, 2025
@P403n1x87
Copy link
Contributor

@Omar-Bishtawi thanks for reporting this. As you have noticed, this should not cause any issues to the application itself (the only nag is the extra noise in logs). We would like to get an understanding of why this might be happening to see if we can reduce the noise, and for this I would like to know if you see any lines in the logs that mention Failed to open debugging contexts, together with a traceback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

No branches or pull requests

3 participants