From d8b7f1a493e49274fba098c5fae5552327558fcd Mon Sep 17 00:00:00 2001 From: Juan Fernandez Date: Thu, 30 Jan 2025 13:42:57 +0100 Subject: [PATCH] extra logs --- .../dynamic-instrumentation/index.js | 2 ++ .../dynamic-instrumentation/worker/index.js | 20 +++++++++++-------- packages/dd-trace/src/plugins/ci_plugin.js | 1 + 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/index.js b/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/index.js index c823ac30a56..df892054786 100644 --- a/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/index.js +++ b/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/index.js @@ -119,6 +119,8 @@ class TestVisDynamicInstrumentation { const onHit = this.onHitBreakpointByProbeId.get(probeId) if (onHit) { onHit({ snapshot }) + } else { + log.warn('Received a breakpoint hit for an unknown probe') } }).unref() diff --git a/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/worker/index.js b/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/worker/index.js index 2b20b5703f9..465e1ff70cc 100644 --- a/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/worker/index.js +++ b/packages/dd-trace/src/ci-visibility/dynamic-instrumentation/worker/index.js @@ -109,15 +109,19 @@ async function addBreakpoint (probe) { } } - const { breakpointId } = await session.post('Debugger.setBreakpoint', { - location: { - scriptId, - lineNumber: lineNumber - 1 - } - }) + try { + const { breakpointId } = await session.post('Debugger.setBreakpoint', { + location: { + scriptId, + lineNumber: lineNumber - 1 + } + }) - breakpointIdToProbe.set(breakpointId, probe) - probeIdToBreakpointId.set(probe.id, breakpointId) + breakpointIdToProbe.set(breakpointId, probe) + probeIdToBreakpointId.set(probe.id, breakpointId) + } catch (e) { + log.error(`Error setting breakpoint at ${path}:${line}:`, e) + } } function start () { diff --git a/packages/dd-trace/src/plugins/ci_plugin.js b/packages/dd-trace/src/plugins/ci_plugin.js index 287d3e6d55d..ee038a60d01 100644 --- a/packages/dd-trace/src/plugins/ci_plugin.js +++ b/packages/dd-trace/src/plugins/ci_plugin.js @@ -346,6 +346,7 @@ module.exports = class CiPlugin extends Plugin { log.warn('Could not add breakpoint for dynamic instrumentation') return } + log.debug('Adding breakpoint for Dynamic Instrumentation') const [probeId, setProbePromise] = this.di.addLineProbe({ file, line }, this.onDiBreakpointHit.bind(this))