Skip to content

Commit cdb4129

Browse files
committed
add db.out tag
1 parent e7758a3 commit cdb4129

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

Diff for: contrib/valkey-go/valkey.go

+1
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ func (c *coreClient) buildStartSpanOptions(input buildStartSpanOptionsInput) []t
187187
tracer.Tag(ext.SpanKind, ext.SpanKindClient),
188188
tracer.Tag(ext.DBSystem, ext.DBSystemValkey),
189189
tracer.Tag(ext.ValkeyDatabaseIndex, c.option.SelectDB),
190+
tracer.Tag("db.out", c.option.SelectDB),
190191
}
191192
opts = append(opts, c.peerTags()...)
192193
if input.command != "" {

Diff for: contrib/valkey-go/valkey_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,8 @@ func TestNewClient(t *testing.T) {
336336
assert.Equal(t, "127.0.0.1", span.Tag(ext.TargetHost))
337337
assert.Equal(t, valkeyPort, span.Tag(ext.PeerPort))
338338
assert.Equal(t, valkeyPort, span.Tag(ext.TargetPort))
339+
assert.Equal(t, 0, span.Tag(ext.ValkeyDatabaseIndex))
340+
assert.Equal(t, 0, span.Tag("db.out"))
339341
assert.NotNil(t, span)
340342
assert.Equal(t, tt.valkeyClientOptions.Username, span.Tag(ext.DBUser))
341343
assert.Equal(t, "valkey.command", span.OperationName())

0 commit comments

Comments
 (0)