Skip to content

Commit 0381840

Browse files
authored
[CORE-283] Disable user suggestions in sharing modals (#5245)
1 parent 0ad2b14 commit 0381840

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/groups/Members/EmailSelect.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ export const EmailSelect: React.FC<EmailSelectProps> = ({
7474
onBlur={handleOnBlur}
7575
onChange={handleOnChange}
7676
height={200}
77+
noOptionsMessage={() => null}
7778
/>
7879
</>
7980
);

src/groups/Members/NewMemberModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export const NewMemberModal = (props: NewMemberModalProps) => {
4444

4545
const signal = useCancellation();
4646

47+
const enableShareLog = false; // Set "true" to enable suggestions
48+
4749
useOnMount(() => {
4850
const loadData = withErrorReporting('Error looking up collaborators')(async () => {
4951
const [shareSuggestions, groups] = await Promise.all([Workspaces(signal).getShareLog(), Groups(signal).list()]);
@@ -52,7 +54,7 @@ export const NewMemberModal = (props: NewMemberModalProps) => {
5254

5355
setSuggestions(suggestions);
5456
});
55-
loadData();
57+
enableShareLog && loadData();
5658
});
5759

5860
const submit = async () => {

src/workspaces/ShareWorkspaceModal/ShareWorkspaceModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ const ShareWorkspaceModal: React.FC<ShareWorkspaceModalProps> = (props: ShareWor
5959

6060
const signal = useCancellation();
6161

62+
const enableShareLog = false; // Set "true" to enable suggestions
63+
6264
// Lifecycle
6365
useOnMount(() => {
6466
const load = async () => {
@@ -100,7 +102,7 @@ const ShareWorkspaceModal: React.FC<ShareWorkspaceModalProps> = (props: ShareWor
100102
_.uniq
101103
)(groups);
102104

103-
const remainingSuggestions = _.difference(suggestions, _.map('email', acl));
105+
const remainingSuggestions = enableShareLog ? _.difference(suggestions, _.map('email', acl)) : [];
104106
const addUserReminder =
105107
'Did you mean to add collaborators? Add them or clear the "User emails" field to save changes.';
106108

0 commit comments

Comments
 (0)