Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in CSP header #2706

Open
dsotirho-ucsc opened this issue Jan 30, 2025 · 1 comment
Open

Typo in CSP header #2706

dsotirho-ucsc opened this issue Jan 30, 2025 · 1 comment
Labels
- [priority] Medium bug [type] A defect preventing use of the system as specified canary Done by the Clever Canary compliance [subject] Information and software security groomed invicti [subject] Represents one or more Invicti findings orange [process] Done by the Azul team

Comments

@dsotirho-ucsc
Copy link
Contributor

Issue:

The Content Security Policy header contains an unquoted none in the frame-src directive. Without quotes, the none value is interpreted as a domain instead of a keyword.

Suggested fix:

Replace frame-src none; with frame-src 'none';

Reproduction:

$ curl --head https://data.humancellatlas.org/
HTTP/2 200
content-type: text/html
content-length: 69868
last-modified: Tue, 21 Jan 2025 18:50:25 GMT
x-amz-server-side-encryption: AES256
accept-ranges: bytes
server: AmazonS3
date: Thu, 30 Jan 2025 18:32:14 GMT
etag: "1aeb1b41f877313f3c0ba707715e242d"
via: 1.1 33296fd8128d04868ae5ae8907ff3c6c.cloudfront.net (CloudFront)
age: 70
cache-control: public, max-age=0, must-revalidate
content-security-policy: default-src 'self'; img-src 'self' data: https://www.google-analytics.com https://www.googletagmanager.com; script-src 'self' 'unsafe-inline' 'unsafe-eval' https://www.google-analytics.com https://www.googletagmanager.com; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com https://use.typekit.net https://p.typekit.net; font-src 'self' data: https://fonts.gstatic.com https://use.typekit.net/af/; object-src 'none'; connect-src 'self' https://www.google-analytics.com https://www.googletagmanager.com https://www.youtube.com; frame-src none; frame-ancestors 'none'; child-src 'none';
strict-transport-security: max-age=63072000; includeSubdomains; preload
x-content-type-options: nosniff
x-frame-options: DENY
x-xss-protection: 1; mode=block
x-cache: Hit from cloudfront
x-amz-cf-pop: SFO53-P2
x-amz-cf-id: 5diUJpAiL2-8Gqa58e7YbrkxUl1akoRT-klvlbiRCrlLWO4d7oksbQ==
@github-actions github-actions bot added the canary Done by the Clever Canary label Jan 30, 2025
@NoopDog
Copy link
Collaborator

NoopDog commented Jan 30, 2025

Thank you @dsotirho-ucsc

@dsotirho-ucsc dsotirho-ucsc added the orange [process] Done by the Azul team label Feb 4, 2025
@achave11-ucsc achave11-ucsc added bug [type] A defect preventing use of the system as specified compliance [subject] Information and software security invicti [subject] Represents one or more Invicti findings - [priority] Medium labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- [priority] Medium bug [type] A defect preventing use of the system as specified canary Done by the Clever Canary compliance [subject] Information and software security groomed invicti [subject] Represents one or more Invicti findings orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

4 participants