Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform deprecation warning for usage of lifecycle_rule #6868

Closed
achave11-ucsc opened this issue Jan 30, 2025 · 2 comments
Closed

Terraform deprecation warning for usage of lifecycle_rule #6868

achave11-ucsc opened this issue Jan 30, 2025 · 2 comments
Labels
orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point wontfix [process] Issue is valid but resolution is not deemed necessary

Comments

@achave11-ucsc
Copy link
Member

achave11-ucsc commented Jan 30, 2025

$ CI_COMMIT_REF_NAME=develop make -C terraform/browser plan

...

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
╷
│ Warning: Argument is deprecated
│
│   with aws_s3_bucket.browser,
│   on browser.tf.json line 62, in resource[0].aws_s3_bucket[0].browser:
│   62:                         "lifecycle_rule": {
│   63:                             "id": "azul-dummy-dev",
│   64:                             "enabled": false,
│   65:                             "expiration": {
│   66:                                 "days": 36500
│   67:                             }
│   68:                         },
│
│ Use the aws_s3_bucket_lifecycle_configuration resource instead
│
│ (and 3 more similar warnings elsewhere)
$ CI_COMMIT_REF_NAME=develop make -C terraform/shared plan

...

Plan: 0 to add, 3 to change, 1 to destroy.
╷
│ Warning: Argument is deprecated
│
│   with aws_s3_bucket.trail,
│   on shared.tf.json line 95, in resource[3].aws_s3_bucket[0].trail:
│   95:                         "lifecycle_rule": {
│   96:                             "id": "azul-dummy-dev",
│   97:                             "enabled": false,
│   98:                             "expiration": {
│   99:                                 "days": 36500
│  100:                             }
│  101:                         },
│
│ Use the aws_s3_bucket_lifecycle_configuration resource instead
│
│ (and 3 more similar warnings elsewhere)
╵
@achave11-ucsc achave11-ucsc added the orange [process] Done by the Azul team label Jan 30, 2025
@dsotirho-ucsc dsotirho-ucsc added the spike:1 [process] Spike estimate of one point label Jan 30, 2025
@dsotirho-ucsc
Copy link
Contributor

Spike to reproduce without -compact-warnings and update description.

@hannes-ucsc
Copy link
Member

hannes-ucsc commented Feb 4, 2025

We created (2c7ada2) these dummy lifecycle rules specificaly to ensure that no other rules exist on the bucket.

I'm doubtful that TF will go forward with the deprecation since there is a valid use case for both methods of specifying a lifecycle rule. The inline method assumes full control, the non-inline method allows for lifecycle rules not controlled by TF.

If TF does in fact remove the inline method, we can easily drop the dummies.

@hannes-ucsc hannes-ucsc added the wontfix [process] Issue is valid but resolution is not deemed necessary label Feb 4, 2025
@hannes-ucsc hannes-ucsc removed their assignment Feb 4, 2025
@hannes-ucsc hannes-ucsc closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point wontfix [process] Issue is valid but resolution is not deemed necessary
Projects
None yet
Development

No branches or pull requests

3 participants