Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/me messages and [permissions] display #55

Open
Artifact0 opened this issue Mar 28, 2019 · 0 comments
Open

/me messages and [permissions] display #55

Artifact0 opened this issue Mar 28, 2019 · 0 comments

Comments

@Artifact0
Copy link

When using the /me styling for messages defined on lines 2906-2908, it ignores the chosen recipient field when determining display. It properly maintains chosen view permissions, on who actually sees it, which is most important; but could lead to confusion when it does not also carry the msgsendmod or similar message permission variable before it in the view frame. With PMs the handling would be more complicated, since it normally displays the recipient name after the sender name. But for [M] [S] or [A] messages, there would be no problem with displaying those variables before the /me message. It seems like it could be done by adapting the code from lines 2867-2882.
I do not run a copy of your chat to test this change on at this time, but hope my description was clear enough to understand the issue I mention and see a way to fix it.
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant