crnlib: fix CodeQL report cpp/comparison-with-wider-type

illwieckz · illwieckz · commit 2e22f1c35487 · 2024-07-11T01:02:09.000+02:00
diff --git a/crnlib/crn_dxt_hc.cpp b/crnlib/crn_dxt_hc.cpp
@@ -374,10 +374,10 @@ void dxt_hc::determine_tiles_task(uint64 data, void*) {
           }
         }
 
-        for (uint8 c = m_has_color_blocks ? 0 : cAlpha0; c < cAlpha0 + m_num_alpha_blocks; c++) {
-          for (uint8 e = 0; e < 8; e++) {
+        for (uint c = m_has_color_blocks ? 0 : cAlpha0; c < cAlpha0 + m_num_alpha_blocks; c++) {
+          for (uint e = 0; e < 8; e++) {
             total_error[c][e] = 0;
-            for (uint8 t = 0, s = e + 1; s; s >>= 1, t++)
+            for (uint t = 0, s = e + 1; s; s >>= 1, t++)
               total_error[c][e] += tile_error[c][tiles[e][t]];
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -374,10 +374,10 @@ void dxt_hc::determine_tiles_task(uint64 data, void*) {`
`374`	`374`	`}`
`375`	`375`	`}`
`376`	`376`
`377`		`- for (uint8 c = m_has_color_blocks ? 0 : cAlpha0; c < cAlpha0 + m_num_alpha_blocks; c++) {`
`378`		`- for (uint8 e = 0; e < 8; e++) {`
	`377`	`+ for (uint c = m_has_color_blocks ? 0 : cAlpha0; c < cAlpha0 + m_num_alpha_blocks; c++) {`
	`378`	`+ for (uint e = 0; e < 8; e++) {`
`379`	`379`	`total_error[c][e] = 0;`
`380`		`- for (uint8 t = 0, s = e + 1; s; s >>= 1, t++)`
	`380`	`+ for (uint t = 0, s = e + 1; s; s >>= 1, t++)`
`381`	`381`	`total_error[c][e] += tile_error[c][tiles[e][t]];`
`382`	`382`	`}`
`383`	`383`	`}`