Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Latest commit

 

History

History
43 lines (29 loc) · 3.33 KB

Contributing Guidelines.rst

File metadata and controls

43 lines (29 loc) · 3.33 KB

The process to contributing is as follows:

  1. Pick an issue that you want to address/fix and assign it to yourself using the "assignees" section on the right side of the issue's page.

    guideline_picturesassign_yourself.png
  2. Start a new branch based on the master branch (this is the default behavior for new branches). If you cannot create a branch, this means you have not accepted or been invited to become part of the DVC-Viking-Robotics organization's github account. This is required! If you create a fork to your own github account, testing is entirely on you, and any hardware dependent changes will not be easy to test (if at all -- depending on your access to the supported hardware ie. Raspberry Pi and assorted sensors).

  3. If your using Visual Studio Code (highly recommended), you have to set up a debugger configuration. While in the "Debug" section ("1" in screenshot) of th VSCode's sidebar, select Add Configuration from the drop down menu ("2" in screenshot). This will open up a launch.json. Edit the launch.json file to look like the following:

    guideline_picturesdebugger_setup.png
    "configurations": [
        {
            "name": "Python: webapp Module",
            "type": "python",
            "request": "launch",
            "module": "webapp.app",
            "console": "integratedTerminal",
            "args": [
                "--port", "5555"
            ]
        }
    ]

    The args array must have a separate string for both the CLI arg option's name and the CLI option's value. The example above specifies the default --port value when not specified.

    If you are using Visual Studio, the process is a little different. If you're developing in a basic text editor, you can test the webapp repository by using following command in a terminal/command prompt/powershell:

    # make sure you are in the webapp repository's root folder
    python -m webapp.app

    To exit, use either the "shutdown server" option from within the webapp's GUI (from the drop-down menu of the power icon in the top right corner) or you could use ctrl+c in the terminal/command prompt/powershell. This keyboardInterupt method is only recommended when the webapp's GUI isn't getting rendered or the "shutdown server" link isn't responding.

  4. When you have a working solution and you are ready to request a merge of your working branch to master, open a "Pull Request" on the webapp repository's webpage. Make sure that the "Pull Request" at the top of the "create Pull Request page" has an arrow leading from your branch to the master branch. Do not merge the "Pull Request" yourself! You should request a review from one of the github organization's owners (2bndy5, guidec, or tejashah88). Again forks will not be tested! Forked contributions' "Pull Request" will be closed. If you have proof (like a screenshot(s)) of your working solution post it in the comments of the "Pull Request".

    guideline_picturesmerge_to_master.png guideline_picturesassign_reviewers.png

If you are looking for how to contribute to the documentation please read our guide on Contributing Documentation.