servie return undefined instead of throwing error (#484)

Author: faiza-jahanzeb

frontend/app/.server/domain/multi-channel/case-api-service-default.ts

@@ -8,12 +8,14 @@ export function getDefaultSinCaseService(): SinCaseService {
   return {
     getSinCases: async (): Promise<SinCaseDto[]> => {
       const response = await fetch(`${serverEnvironment.INTEROP_SIN_REG_API_BASE_URL}/cases`);
+      if (response.status === 404) return [];
       if (!response.ok) throw new AppError(`Cases not found.`, ErrorCodes.SIN_CASE_NOT_FOUND);
       return response.json();
     },
 
-    getSinCaseById: async (id: string): Promise<SinCaseDto> => {
+    getSinCaseById: async (id: string): Promise<SinCaseDto | undefined> => {
       const response = await fetch(`${serverEnvironment.INTEROP_SIN_REG_API_BASE_URL}/cases/${id}`);
+      if (response.status === 404) return undefined;
       if (!response.ok) throw new AppError(`Case with ID '${id}' not found.`, ErrorCodes.SIN_CASE_NOT_FOUND);
       return response.json();
     },

frontend/app/.server/domain/multi-channel/case-api-service.ts

@@ -5,7 +5,7 @@ import { serverEnvironment } from '~/.server/environment';
 
 export type SinCaseService = {
   getSinCases(): Promise<SinCaseDto[]>;
-  getSinCaseById(id: string): Promise<SinCaseDto>;
+  getSinCaseById(id: string): Promise<SinCaseDto | undefined>;
 };
 
 export function getSinCaseService(): SinCaseService {

frontend/app/routes/protected/multi-channel/send-validation.tsx

@@ -26,6 +26,7 @@ import { InlineLink } from '~/components/links';
 import { PageTitle } from '~/components/page-title';
 import { AppError } from '~/errors/app-error';
 import { ErrorCodes } from '~/errors/error-codes';
+import { HttpStatusCodes } from '~/errors/http-status-codes';
 import { getTranslation } from '~/i18n-config.server';
 import { handle as parentHandle } from '~/routes/protected/person-case/layout';
 import { ReviewBirthDetails } from '~/routes/protected/sin-application/review-birth-details';
@@ -68,6 +69,12 @@ export async function loader({ context, request }: Route.LoaderArgs) {
   // TODO: the id will likely come from a path param in the URL?
   const personSinCase = await getSinCaseService().getSinCaseById('000000000');
 
+  if (personSinCase === undefined) {
+    throw new Response(JSON.stringify({ status: HttpStatusCodes.NOT_FOUND, message: 'Case not found' }), {
+      status: HttpStatusCodes.NOT_FOUND,
+    });
+  }
+
   const {
     birthDetails,
     contactInformation,