fix(frontend): state machine regression (setFormData)

Author: gregory-j-baker

frontend/app/routes/protected/person-case/state-machine.server.ts

@@ -105,6 +105,11 @@ export const machine = setup({
     exit: {
       target: '.exited',
     },
+    setFormData: {
+      actions: assign(({ context, event }) => ({
+        formData: { ...context.formData, ...event.data },
+      })),
+    },
   },
   states: {
     'exited': { type: 'final' },

frontend/app/routes/protected/person-case/validation.server.ts

@@ -8,6 +8,7 @@ import { getApplicationSubmissionScenarios } from '~/.server/domain/person-case/
 import { getTypesOfApplicationToSubmit } from '~/.server/domain/person-case/services/application-type-service';
 import { serverEnvironment } from '~/.server/environment';
 import { countryService, provinceService } from '~/.server/shared/services';
+import { stringToIntegerSchema } from '~/.server/validation/string-to-integer-schema';
 import { APPLICANT_STATUS_IN_CANADA } from '~/domain/constants';
 import { getStartOfDayInTimezone, isDateInPastOrTodayInTimeZone, isValidDateString } from '~/utils/date-utils';
 import { REGEX_PATTERNS } from '~/utils/regex-utils';
@@ -407,23 +408,20 @@ export const primaryDocumentSchema = v.intersect([
           v.regex(REGEX_PATTERNS.NON_DIGIT, 'protected:primary-identity-document.last-name.format'),
         ),
         dateOfBirthYear: v.pipe(
-          v.number('protected:primary-identity-document.date-of-birth.required-year'),
-          v.integer('protected:primary-identity-document.date-of-birth.invalid-year'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.date-of-birth.invalid-year'),
           v.maxValue(
             getStartOfDayInTimezone(serverEnvironment.BASE_TIMEZONE).getFullYear(),
             'protected:primary-identity-document.date-of-birth.invalid-year',
           ),
         ),
         dateOfBirthMonth: v.pipe(
-          v.number('protected:primary-identity-document.date-of-birth.required-month'),
-          v.integer('protected:primary-identity-document.date-of-birth.invalid-month'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.date-of-birth.invalid-month'),
           v.maxValue(12, 'protected:primary-identity-document.date-of-birth.invalid-month'),
         ),
         dateOfBirthDay: v.pipe(
-          v.number('protected:primary-identity-document.date-of-birth.required-day'),
-          v.integer('protected:primary-identity-document.date-of-birth.invalid-day'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.date-of-birth.invalid-day'),
           v.maxValue(31, 'protected:primary-identity-document.date-of-birth.invalid-day'),
         ),
@@ -442,23 +440,20 @@ export const primaryDocumentSchema = v.intersect([
           ),
         ),
         citizenshipDateYear: v.pipe(
-          v.number('protected:primary-identity-document.citizenship-date.required-year'),
-          v.integer('protected:primary-identity-document.citizenship-date.invalid-year'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.citizenship-date.invalid-year'),
           v.maxValue(
             getStartOfDayInTimezone(serverEnvironment.BASE_TIMEZONE).getFullYear(),
             'protected:primary-identity-document.citizenship-date.invalid-year',
           ),
         ),
         citizenshipDateMonth: v.pipe(
-          v.number('protected:primary-identity-document.citizenship-date.required-month'),
-          v.integer('protected:primary-identity-document.citizenship-date.invalid-month'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.citizenship-date.invalid-month'),
           v.maxValue(12, 'protected:primary-identity-document.citizenship-date.invalid-month'),
         ),
         citizenshipDateDay: v.pipe(
-          v.number('protected:primary-identity-document.citizenship-date.required-day'),
-          v.integer('protected:primary-identity-document.citizenship-date.invalid-day'),
+          stringToIntegerSchema(),
           v.minValue(1, 'protected:primary-identity-document.citizenship-date.invalid-day'),
           v.maxValue(31, 'protected:primary-identity-document.citizenship-date.invalid-day'),
         ),