Skip to content

Commit 4398ae5

Browse files
vmcjnickygerritsen
authored andcommitted
Fail on PHPStan errors
In the past we would get the annotation but the pipeline stopped failing. This resulted in some PHPStan findings not being handled. We could consider removing the GH action but that would remove the annotations.
1 parent b77962c commit 4398ae5

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

.github/workflows/phpstan.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,16 @@ jobs:
1515
run: .github/jobs/composer_setup.sh
1616
- name: Show the phpstan version
1717
run: webapp/vendor/phpstan/phpstan/phpstan --version
18+
- name: Run PHPStan in the classic way
19+
run: |
20+
set -euo pipefail
21+
webapp/vendor/bin/phpstan \
22+
--configuration=webapp/phpstan.dist.neon \
23+
| tee /tmp/artifacts/phpstan.out
24+
# Run the test again for GHA annotations
1825
- uses: php-actions/[email protected]
1926
with:
2027
configuration: webapp/phpstan.dist.neon
21-
path: webapp/src webapp/tests
2228
php_extensions: gd intl mysqli pcntl zip
2329
autoload_file: webapp/vendor/autoload.php
2430
version: composer

0 commit comments

Comments
 (0)