Skip to content

Commit 08698eb

Browse files
committed
Move php-compatibility maintainance to our own container
For [phpcs_compatibility](https://github.com/DOMjudge/domjudge/blob/main/.github/workflows/codestyle.yml). We used another container for simplicity of maintainance, then we needed to hotpatch the container for PHP84 for the `$this` & `enums`. The plan was to do this while waiting for version 10 of the tool. Since then we've had to patch the container more and more so the "lower" maintenance cost are now in installing the tool on it's own.
1 parent 82f892d commit 08698eb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docker-gitlabci/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ RUN su domjudge -c "cd /home/domjudge && \
3737
npm cache clean --force"
3838

3939
# Install needed global PHP modules
40-
RUN composer -n require justinrainbow/json-schema
40+
RUN composer -n require justinrainbow/json-schema phpcompatibility/php-compatibility:dev-develop
4141

4242
# Install other PHP versions
4343
RUN add-apt-repository ppa:ondrej/php -y && apt-get update && \

0 commit comments

Comments
 (0)