Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slave allowed error calc #1

Open
DAVe3283 opened this issue May 7, 2016 · 0 comments
Open

Fix slave allowed error calc #1

DAVe3283 opened this issue May 7, 2016 · 0 comments

Comments

@DAVe3283
Copy link
Owner

DAVe3283 commented May 7, 2016

The current method of calculating the allowed error on each slave board is based on how many chimes that particular slave is currently striking. This was done to work around an issue where the voltage would drop as the number of chimes struck at once went up, but it turns out I was just exceeding the rating of the power supply. Plus, they have no way of knowing how many chimes the other slaves (of which they also don't know) are striking, so this method is fundamentally flawed.

The master should control how many chimes can be struck simultaneously, and the slaves should just have a reasonable error limit (e.g. 2-5%). If a measurement is out of range, it is probably a good idea to shut down the power supply, because something is wrong. I just thought it wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@DAVe3283 and others