Skip to content

Commit 424d591

Browse files
committed
1.1.3: Compatible with IntelliJ IDEA 2019.3
1 parent 01d0535 commit 424d591

File tree

4 files changed

+26
-14
lines changed

4 files changed

+26
-14
lines changed

src/main/java/com/cybrosis/catdea/index/CatdeaIndex.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
/**
3939
* @author cybrosis
4040
*/
41-
public class CatdeaIndex extends FileBasedIndexExtension<String, Collection<CatdeaIndexEntry>> implements PsiDependentIndex {
41+
public class CatdeaIndex extends FileBasedIndexExtension<String, Collection<CatdeaIndexEntry>> {
4242
public static final ID<String, Collection<CatdeaIndexEntry>> INDEX_ID = ID.create("com.cybrosis.catdea.index");
4343

4444
private static final CatdeaIndexer INDEXER = new CatdeaIndexer();
@@ -92,7 +92,7 @@ public void visitLiteralExpression(PsiLiteralExpression expression) {
9292

9393
@Override
9494
public int getVersion() {
95-
return 2;
95+
return 3;
9696
}
9797

9898
@NotNull

src/main/java/com/cybrosis/catdea/index/PsiDataIndexer.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.intellij.psi.PsiFile;
2121
import com.intellij.util.indexing.DataIndexer;
2222
import com.intellij.util.indexing.FileContent;
23-
import com.intellij.util.indexing.FileContentImpl;
2423
import org.jetbrains.annotations.NotNull;
2524

2625
import java.util.Map;
@@ -32,11 +31,9 @@ public abstract class PsiDataIndexer<Key, Value> implements DataIndexer<Key, Val
3231
@NotNull
3332
@Override
3433
public Map<Key, Value> map(@NotNull FileContent inputData) {
35-
final PsiFile psiFile = ((FileContentImpl) inputData).getPsiFileForPsiDependentIndex();
36-
3734
return DumbService
3835
.getInstance(inputData.getProject())
39-
.computeWithAlternativeResolveEnabled(() -> map(psiFile));
36+
.computeWithAlternativeResolveEnabled(() -> map(inputData.getPsiFile()));
4037
}
4138

4239
@NotNull

src/main/java/com/cybrosis/catdea/toolWindow/CatdeaToolWindowFactory.java

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,22 @@
1616

1717
package com.cybrosis.catdea.toolWindow;
1818

19+
import com.android.ddmlib.AndroidDebugBridge;
1920
import com.android.tools.idea.adb.AdbService;
21+
import com.android.tools.idea.concurrent.EdtExecutor;
2022
import com.cybrosis.catdea.icons.CatdeaIcons;
21-
import com.google.common.util.concurrent.MoreExecutors;
23+
import com.google.common.util.concurrent.FutureCallback;
24+
import com.google.common.util.concurrent.Futures;
25+
import com.google.common.util.concurrent.ListenableFuture;
2226
import com.intellij.openapi.project.Project;
27+
import com.intellij.openapi.ui.Messages;
2328
import com.intellij.openapi.wm.ToolWindow;
2429
import com.intellij.openapi.wm.ToolWindowFactory;
2530
import com.intellij.ui.content.Content;
2631
import com.intellij.ui.content.ContentManager;
2732
import org.jetbrains.android.sdk.AndroidSdkUtils;
2833
import org.jetbrains.annotations.NotNull;
34+
import org.jetbrains.annotations.Nullable;
2935

3036
import java.io.File;
3137

@@ -48,11 +54,18 @@ public void createToolWindowContent(@NotNull Project project, @NotNull ToolWindo
4854
catdeaLogcatPanel.setLoadingText("Initializing ADB");
4955
catdeaLogcatPanel.startLoading();
5056

51-
AdbService.getInstance()
52-
.getDebugBridge(adb)
53-
.addListener(
54-
catdeaLogcatPanel::stopLoading,
55-
MoreExecutors.directExecutor()
56-
);
57+
final ListenableFuture<AndroidDebugBridge> future = AdbService.getInstance().getDebugBridge(adb);
58+
Futures.addCallback(future, new FutureCallback<AndroidDebugBridge>() {
59+
@Override
60+
public void onSuccess(@Nullable AndroidDebugBridge bridge) {
61+
catdeaLogcatPanel.stopLoading();
62+
}
63+
64+
@Override
65+
public void onFailure(@NotNull Throwable t) {
66+
catdeaLogcatPanel.stopLoading();
67+
Messages.showErrorDialog(AdbService.getDebugBridgeDiagnosticErrorMessage(t, adb), "ADB Connection Error");
68+
}
69+
}, EdtExecutor.INSTANCE);
5770
}
5871
}

src/main/resources/META-INF/plugin.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<idea-plugin>
22
<id>com.cybrosis.catdea</id>
33
<name>Catdea</name>
4-
<version>1.1.2</version>
4+
<version>1.1.3</version>
55
<vendor email="[email protected]" url="https://github.com/Cybr0sis/Catdea">Cybrosis</vendor>
66

77
<description><![CDATA[
@@ -26,6 +26,7 @@
2626
]]></description>
2727

2828
<change-notes><![CDATA[
29+
<p>1.1.3: Compatible with IntelliJ IDEA 2019.3</p>
2930
<p>1.1.2: Fixed icons and minor refactoring</p>
3031
<p>1.1.1: Fixed issue#4: NPE occurred in CatdeaServiceImpl.projectJdkChanged</p>
3132
<p>1.1: Added Logcat Monitor Tool Window</p>
@@ -48,6 +49,7 @@
4849

4950
<fileType
5051
name="Catdea"
52+
language="CatdeaLanguage"
5153
implementationClass="com.cybrosis.catdea.files.CatdeaFileType"
5254
fieldName="INSTANCE"
5355
extensions="log;logcat;logdump"/>

0 commit comments

Comments
 (0)