fix: remove trigger

Author: ulemons

backend/src/database/migrations/V1753110221__create_insights_repo_table.sql

@@ -11,97 +11,3 @@ CREATE TABLE IF NOT EXISTS "insightsProjectsRepositories" (
 CREATE UNIQUE INDEX IF NOT EXISTS unique_active_insights_project_repo
 ON "insightsProjectsRepositories" (repository)
 WHERE "deletedAt" IS NULL;
-
--- 3. Create or replace the sync function
-CREATE OR REPLACE FUNCTION sync_repositories()
-RETURNS TRIGGER AS $function$
-DECLARE
-    repo TEXT;
-    i INT;
-    project_id UUID := COALESCE(NEW.id, OLD.id);
-BEGIN
-    RAISE WARNING 'Trigger fired with operation: %, project ID: %', TG_OP, project_id;
-
-    -- DELETE: soft-delete all repositories when a project is deleted
-    IF TG_OP = 'DELETE' THEN
-        RAISE WARNING 'Soft-deleting all repositories for deleted project %', project_id;
-
-        UPDATE "insightsProjectsRepositories"
-        SET "deletedAt" = CURRENT_TIMESTAMP
-        WHERE "insightsProjectId" = project_id AND "deletedAt" IS NULL;
-
-        RETURN OLD;
-    END IF;
-
-    -- INSERT or UPDATE: shared logic
-    IF TG_OP IN ('INSERT', 'UPDATE') THEN
-        -- On UPDATE, skip if repositories did not change
-        IF TG_OP = 'UPDATE' AND OLD.repositories IS NOT DISTINCT FROM NEW.repositories THEN
-            RAISE WARNING 'Repositories unchanged for project %, skipping update logic', project_id;
-            RETURN NEW;
-        END IF;
-
-        -- On UPDATE: soft-delete only removed repositories
-        IF TG_OP = 'UPDATE' THEN
-            RAISE WARNING 'Soft-deleting removed repositories for project %', project_id;
-
-            UPDATE "insightsProjectsRepositories"
-            SET "deletedAt" = CURRENT_TIMESTAMP
-            WHERE "insightsProjectId" = project_id
-              AND "deletedAt" IS NULL
-              AND repository NOT IN (SELECT unnest(NEW.repositories));
-        END IF;
-
-        -- If no repositories provided, exit
-        IF NEW.repositories IS NULL THEN
-            RAISE WARNING 'No repositories to insert for project %', project_id;
-            RETURN NEW;
-        END IF;
-
-        RAISE WARNING 'Processing repositories for project %', project_id;
-
-        -- Loop through repositories and insert or revive
-        FOR i IN COALESCE(array_lower(NEW.repositories, 1), 1)..COALESCE(array_upper(NEW.repositories, 1), 0)
-        LOOP
-            repo := NEW.repositories[i];
-            RAISE WARNING 'Ensuring repository "%", project ID: %', repo, project_id;
-
-            -- Check if this repo is already assigned to another active project
-            PERFORM 1 FROM "insightsProjectsRepositories"
-            WHERE repository = repo
-              AND "insightsProjectId" != project_id
-              AND "deletedAt" IS NULL;
-
-            IF FOUND THEN
-                RAISE EXCEPTION 'Repository "%" is already assigned to another project.', repo;
-            END IF;
-
-            -- Try to revive a previously soft-deleted record
-            UPDATE "insightsProjectsRepositories"
-            SET "deletedAt" = NULL, "createdAt" = CURRENT_TIMESTAMP
-            WHERE repository = repo
-              AND "insightsProjectId" = project_id
-              AND "deletedAt" IS NOT NULL;
-
-            -- If not found, insert new
-            IF NOT FOUND THEN
-                INSERT INTO "insightsProjectsRepositories" (repository, "insightsProjectId")
-                VALUES (repo, project_id)
-                ON CONFLICT DO NOTHING;
-            END IF;
-        END LOOP;
-
-        RETURN NEW;
-    END IF;
-
-    RETURN NULL;
-END;
-$function$ LANGUAGE plpgsql;
-
--- 4. Create the trigger to call the function on INSERT, UPDATE, DELETE
-DROP TRIGGER IF EXISTS trg_insights_projects_repositories_sync ON "insightsProjects";
-
-CREATE TRIGGER trg_insights_projects_repositories_sync
-AFTER INSERT OR DELETE OR UPDATE ON "insightsProjects"
-FOR EACH ROW
-EXECUTE FUNCTION sync_repositories();

backend/src/services/collectionService.ts

@@ -20,8 +20,10 @@ import {
   queryCollections,
   queryInsightsProjectById,
   queryInsightsProjects,
+  softDeleteInsightsProjectRepositories,
   updateCollection,
   updateInsightsProject,
+  upsertInsightsProjectRepositories,
 } from '@crowd/data-access-layer/src/collections'
 import { fetchIntegrationsForSegment } from '@crowd/data-access-layer/src/integrations'
 import { OrganizationField, findOrgById, queryOrgs } from '@crowd/data-access-layer/src/orgs'
@@ -362,6 +364,19 @@ export class CollectionService extends LoggerBase {
       offset,
     }
   }
+ 
+  static normalizeRepositories(
+  repositories?: string[] | { platform: string; url: string }[]
+): string[] {
+  if (!repositories) return [];
+
+  if (typeof repositories[0] === 'string') {
+    return repositories as string[];
+  }
+
+  return (repositories as { platform: string; url: string }[]).map(r => r.url);
+}
+
 
   async updateInsightsProject(id: string, project: Partial<ICreateInsightsProject>) {
     return SequelizeRepository.withTx(this.options, async (tx) => {
@@ -375,6 +390,18 @@ export class CollectionService extends LoggerBase {
 
       await updateInsightsProject(qx, id, project)
 
+      console.log(`repositories: ${project.repositories} and id: ${id}`)
+      
+      if (project.repositories?.length > 0) {
+        // TODO: sistemare tutto in modo che le repository possono essere anche zero
+        const repositories = CollectionService.normalizeRepositories(project.repositories)
+  
+        await upsertInsightsProjectRepositories(qx, `${id}`, repositories)
+  
+        await softDeleteInsightsProjectRepositories(qx, id, repositories)
+      }
+
+
       if (project.collections) {
         await disconnectProjectsAndCollections(qx, { insightsProjectId: id })
         await connectProjectsAndCollections(

services/libs/data-access-layer/src/collections/index.ts

@@ -294,3 +294,33 @@ export async function findBySlug(qx: QueryExecutor, slug: string) {
   })
   return collections
 }
+
+export async function upsertInsightsProjectRepositories(qx: QueryExecutor, insightsProjectId, repositories: string[]) {
+  const data = repositories.map((repo) => ({
+    insightsProjectId,
+    repository: repo,
+  }))
+  
+  return qx.result(
+    prepareBulkInsert(
+      'insightsProjectsRepositories',
+      ['insightsProjectId', 'repository'],
+      data,
+      'do nothing',
+    ),
+  )
+}
+
+export async function softDeleteInsightsProjectRepositories(
+  qx: QueryExecutor,
+  insightsProjectId: string,
+  currentRepositories: string[],
+): Promise<void> {
+  return qx.result(`
+    UPDATE "insightsProjectsRepositories"
+    SET "deletedAt" = NOW()
+    WHERE "insightsProjectId" = '${insightsProjectId}'
+      AND "deletedAt" IS NULL
+      AND "repository" NOT IN (${currentRepositories.map(repo => `'${repo}'`).join(', ')})
+  `, { insightsProjectId, currentRepositories } )
+}