Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Link ignores sign line length limits #8065

Open
SlimeCubed opened this issue Mar 21, 2025 · 2 comments
Open

Display Link ignores sign line length limits #8065

SlimeCubed opened this issue Mar 21, 2025 · 2 comments
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working type: crash Issue where the game crashes

Comments

@SlimeCubed
Copy link

Description

Display links can write long lines of text to signs, much longer than the normal limit.

Attempting to edit a sign with way too much text crashes the client: https://github.com/user-attachments/assets/a9019331-4d76-4c3c-99ef-19f44f4a3480

Game Log

https://mclo.gs/sGMcAbF

Debug Information

Client Info
Create:
	Mod Version: 6.0.3
	Mod Git Commit: 7f14bcc64b0eed202617fe08f0dbf5a1e74443d3
	Ponder Version: 1.0.45
	NeoForge Version: 21.1.136
	Minecraft Version: 1.21.1

Graphics:
	Flywheel Version: 1.0.1-11
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: AMD Radeon(TM) Graphics
	OpenGL Version: 4.6.14756 Core Profile Forward-Compatible Context 20.40.52 27.20.14052.10
	Graphics Mode: Fast

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.3, Microsoft
	JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m
	Memory: 594606192 bytes (567 MiB) / 1379926016 bytes (1316 MiB) up to 4294967296 bytes (4096 MiB)
	Total Memory: 790546304 bytes (753 MiB) / 1379926016 bytes (1316 MiB)
	CPU: AMD Ryzen 7 5800U with Radeon Graphics @ 1.90 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
Server Info
Create:
	Mod Version: 6.0.3
	Mod Git Commit: 7f14bcc64b0eed202617fe08f0dbf5a1e74443d3
	Ponder Version: 1.0.45
	NeoForge Version: 21.1.136
	Minecraft Version: 1.21.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.3, Microsoft
	JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m
	Memory: 594606192 bytes (567 MiB) / 1379926016 bytes (1316 MiB) up to 4294967296 bytes (4096 MiB)
	Total Memory: 790546304 bytes (753 MiB) / 1379926016 bytes (1316 MiB)
	CPU: AMD Ryzen 7 5800U with Radeon Graphics @ 1.90 GHz; 8 cores / 16 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
@SlimeCubed SlimeCubed added the type: bug Issue where something isn't working label Mar 21, 2025
@SlimeCubed
Copy link
Author

This also means packages can have really long addresses. Here I use two display links to double the length of the package address each iteration, eventually crashing my singleplayer world. Attempting to start the world again fails with the message "Disconnected"
https://github.com/user-attachments/assets/e1d1ecc7-3059-4599-97aa-90d138995391

@VoidLeech VoidLeech added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Mar 22, 2025
@VoidLeech
Copy link
Collaborator

Crash in singleplayer happens only in 1.21.1

@VoidLeech VoidLeech added the type: crash Issue where the game crashes label Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working type: crash Issue where the game crashes
Projects
None yet
Development

No branches or pull requests

2 participants