Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about boundary sample map weight #17

Open
yueyue1009 opened this issue Jan 31, 2024 · 0 comments
Open

Question about boundary sample map weight #17

yueyue1009 opened this issue Jan 31, 2024 · 0 comments

Comments

@yueyue1009
Copy link

Hi, thanks for the great work, I have a question about the function get_pem_smp_weight() of model.boundary_module.py.

At line 77 you assigned xmax = (j + 1), and at line 79 length = xmax - xmin. Based on your paper and the comment written in the file, I thought that xmax should be (i + j + 1) and length = (j + 1).

Consider a case that i = 10, and j = 0, in this case, xmax = 1, length = -9. it is quite confusing to me that how length < 0 mean.

Thanks for reading, please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant