feat: trace all previous blockhashes #2353

letypequividelespoubelles · 2025-09-29T13:13:27Z

Note

Plumbs historical block-hash collection into tracing and replay: gather prior hashes, add last-block hash, and wire through BlockCapturer, ZkTracer/Hub, RPC, and tests with EIP-2935/4788 touches.

Blockhash tracing & replay:
- Replace BlockHashReaper with map-based storage in Reaper; add consistency checks; include EIP-2935/4788 system-tx touches.
- Overhaul module/blockhash to track first/last blocks, inject historical hashes, add parent-hash op, auto-emit missing historical calls, and include last-block placeholder; BlockhashOperation now uses Hash.
- ConflationSnapshot: new from(...), historicalBlockHashes(), refined toBlockHashLookup.
Tracer/Hub plumbing:
- ZkTracer and all *Hub constructors accept historical hashes and pass to Blockhash.
- Fork.getForkFromBesuBlockchainService overload for BlockchainService.
- ZkCounter: count blockhash lines at conflation start; fix counting loops and report unchecked modules as 0.
Capture/RPC:
- CaptureToFile/GenerateConflatedTracesV2: fetch fork and historical block hashes from BlockchainService and pass to BlockCapturer/ZkTracer.
- BlockCapturer: accept historical hashes, record end-block hash, and simplify per-opcode handling.
Snapshots:
- BlockHeaderSnapshot: store parentBeaconBlockRoot as optional hex string with null-guard.
Tests & utilities:
- Replay and toy environments parse conflations first, derive and pass historical hashes; add Prague Sepolia tests; adjust defaults to Prague; minor disables.

^{Written by Cursor Bugbot for commit 077d742. This will update automatically on new commits. Configure here.}

Signed-off-by: F Bojarski <[email protected]>

…nflation

Signed-off-by: F Bojarski <[email protected]>

…cks of the chain Signed-off-by: F Bojarski <[email protected]>

Signed-off-by: F Bojarski <[email protected]>

testing/src/main/java/net/consensys/linea/testing/ToyExecutionEnvironmentV2.java

Signed-off-by: F Bojarski <[email protected]>

…nflation

Signed-off-by: F Bojarski <[email protected]>

This changes the type of the field parentBeaconBlockRoot in BlockHeaderSnapshot to be an (optional) String instead of a Bytes32 instance. This is to avoid decoding issues because the GSONDecoder is not aware of the Bytes32 type.

The clique consensus protocol was only used prior to shanghai, hence we cannot extract key information from block headers generated from Shanghai nodes and onwards.

This restores this component, whilst retaining flexibility around the use of Map<Long,Hash>. The goal is simply to ensure all block hashes are stored in the JSON file as hex strings.

Signed-off-by: F Bojarski <[email protected]>

This puts in fixes for the methods Reaper.touchBlockHash() and also ConflationSnapshot.from(), and applies spotless.

Signed-off-by: F Bojarski <[email protected]>

OlivierBBB

Not much of a review. One potential issue in the logic wrt the keys at which the EIP4788_BEACONROOT_ADDRESS contract's storage gets probed.

OlivierBBB · 2025-10-24T14:58:32Z

arithmetization/src/main/java/net/consensys/linea/blockcapture/reapers/Reaper.java

+      final UInt256 timestamp = UInt256.valueOf(header.getTimestamp());
+      final UInt256 keyTimestamp = timestamp.mod(HISTORY_BUFFER_LENGTH);
+      conflationStorage.touch(EIP4788_BEACONROOT_ADDRESS, timestamp);
+      conflationStorage.touch(EIP4788_BEACONROOT_ADDRESS, keyTimestamp);


The keys that are touched by 4788 system transactions are

brKey := timestamp mod 8191 tsKey := brKey + 8191

Am I misunderstanding here ?

nope, you're right

OlivierBBB · 2025-10-24T17:36:36Z

arithmetization/src/test/java/net/consensys/linea/replaytests/ReplayTests.java

    replay(OLD_MAINNET_TESTCONFIG, "4323985.mainnet.json.gz", testInfo);
  }

+  @Disabled("Fails to create the ConflationSnapshot from the gson file")


Should this read json ? (Several cases in this file, but I also see gson in other places)

OlivierBBB · 2025-10-24T17:47:39Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/blockhash/Blockhash.java

+    checkBlockHashConsistancies(e);
+  }
+
+  private void checkBlockHashConsistancies(BlockhashOperation op) {


Typo checkBlockHashConsistencies

feat: trace all previous blockhashes

cdb6bd7

Signed-off-by: F Bojarski <[email protected]>

letypequividelespoubelles linked an issue Sep 29, 2025 that may be closed by this pull request

Add previous blockhashes to the conflation #2348

Closed

letypequividelespoubelles self-assigned this Sep 29, 2025

letypequividelespoubelles marked this pull request as draft September 29, 2025 13:13

This comment was marked as outdated.

Sign in to view

letypequividelespoubelles added 4 commits September 30, 2025 14:12

feat: some stuff

3291986

Signed-off-by: F Bojarski <[email protected]>

Merge branch 'arith-dev' into 2348-add-previous-blockhashes-to-the-co…

a1e59dc

…nflation

rebase

1fe4014

Signed-off-by: F Bojarski <[email protected]>

rm the try catch, if else is better + fix when dealing with first blo…

a65dbec

…cks of the chain Signed-off-by: F Bojarski <[email protected]>

letypequividelespoubelles marked this pull request as ready for review October 1, 2025 04:03

This comment was marked as outdated.

Sign in to view

letypequividelespoubelles added 2 commits October 1, 2025 09:39

fix line counting

f7c987f

Signed-off-by: F Bojarski <[email protected]>

spotless

374fe0d

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

letypequividelespoubelles added 3 commits October 1, 2025 09:50

update corset

12e274c

Signed-off-by: F Bojarski <[email protected]>

ras

d3283b9

Signed-off-by: F Bojarski <[email protected]>

rebase

55556e2

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

letypequividelespoubelles added 4 commits October 1, 2025 12:44

ras

1fde88d

Signed-off-by: F Bojarski <[email protected]>

ras rebase

53257e6

Signed-off-by: F Bojarski <[email protected]>

add blockhash line count at begining of the conflation in zktracer

c964177

Signed-off-by: F Bojarski <[email protected]>

test: move blockhash test to besu node tests

284f8b7

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

amkCha reviewed Oct 1, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/ToyExecutionEnvironmentV2.java Outdated Show resolved Hide resolved

letypequividelespoubelles added 5 commits October 1, 2025 18:08

fix: wrong cast to short

afc5d85

Signed-off-by: F Bojarski <[email protected]>

rebase

01e6802

Signed-off-by: F Bojarski <[email protected]>

ras rebase

b07cbc9

Signed-off-by: F Bojarski <[email protected]>

ras

860d03d

Signed-off-by: F Bojarski <[email protected]>

default constructor wo blockchainservices

b8bbcf5

Signed-off-by: F Bojarski <[email protected]>

ras

5a592bb

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

fix: don't call blockhash if exceptional

0046e4c

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

letypequividelespoubelles and others added 10 commits October 15, 2025 16:13

retrieve historical blockhaseh for replay tests

c1068c8

Signed-off-by: F Bojarski <[email protected]>

test: skip tests where we can't extract data from gson

27b52fe

Signed-off-by: F Bojarski <[email protected]>

tmp: gradle properties

b973e31

Signed-off-by: F Bojarski <[email protected]>

add tests for sepolia replay preparation

c34f97d

Signed-off-by: F Bojarski <[email protected]>

Merge branch 'arith-dev' into 2348-add-previous-blockhashes-to-the-co…

91cf927

…nflation

add system tx for block capturer

3bc11d6

Signed-off-by: F Bojarski <[email protected]>

ras

4746eca

Signed-off-by: F Bojarski <[email protected]>

Encode/decode parentBeaconBlockRoot as hex string

27addb1

This changes the type of the field parentBeaconBlockRoot in BlockHeaderSnapshot to be an (optional) String instead of a Bytes32 instance. This is to avoid decoding issues because the GSONDecoder is not aware of the Bytes32 type.

don't load clique headers from Shanghai onwards

fa1b3bd

The clique consensus protocol was only used prior to shanghai, hence we cannot extract key information from block headers generated from Shanghai nodes and onwards.

restore BlockHashSnapshot

42a2230

This restores this component, whilst retaining flexibility around the use of Map<Long,Hash>. The goal is simply to ensure all block hashes are stored in the JSON file as hex strings.

This comment was marked as outdated.

Sign in to view

DavePearce and others added 8 commits October 17, 2025 16:59

minor fixes

5c64388

add replay tests and little debug

febd637

Signed-off-by: F Bojarski <[email protected]>

ras

c6df212

Signed-off-by: F Bojarski <[email protected]>

rebase

f06c44b

Signed-off-by: F Bojarski <[email protected]>

fix Reaper and ConflationSnapshot

077effe

This puts in fixes for the methods Reaper.touchBlockHash() and also ConflationSnapshot.from(), and applies spotless.

add replay tests from PRAGUE

b0dc1c5

rebase

599cee0

Signed-off-by: F Bojarski <[email protected]>

rebase

62e8170

Signed-off-by: F Bojarski <[email protected]>

This comment was marked as outdated.

Sign in to view

nothing important

077d742

Signed-off-by: F Bojarski <[email protected]>

letypequividelespoubelles enabled auto-merge (squash) October 24, 2025 16:56

letypequividelespoubelles merged commit d6d5e90 into arith-dev Oct 24, 2025
14 of 15 checks passed

letypequividelespoubelles deleted the 2348-add-previous-blockhashes-to-the-conflation branch October 24, 2025 17:20

OlivierBBB reviewed Oct 24, 2025

View reviewed changes

letypequividelespoubelles mentioned this pull request Oct 24, 2025

The keys that are touched by 4788 system transactions are #2446

Open

feat: trace all previous blockhashes #2353

feat: trace all previous blockhashes #2353

Uh oh!

Conversation

letypequividelespoubelles commented Sep 29, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

OlivierBBB left a comment

Choose a reason for hiding this comment

Uh oh!

OlivierBBB Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

letypequividelespoubelles Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

OlivierBBB Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

OlivierBBB Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

letypequividelespoubelles commented Sep 29, 2025 •

edited by cursor bot

Loading