Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dark theme #192

Open
1 task
raulb opened this issue Nov 14, 2024 · 2 comments
Open
1 task

feat: enable dark theme #192

raulb opened this issue Nov 14, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@raulb
Copy link
Member

raulb commented Nov 14, 2024

Enabling dark theme in docusaurus is trivial (set this to false), but we need to update the images and styles so they still look good:

  • Refer to data-theme="dark" or data-theme="light"

CleanShot 2024-11-14 at 08 53 52@2x

CleanShot 2024-11-14 at 08 54 07@2x

CleanShot 2024-11-14 at 08 54 18@2x

CleanShot 2024-11-14 at 08 54 45@2x

CleanShot 2024-11-14 at 08 54 55@2x

@hariso
Copy link
Contributor

hariso commented Nov 14, 2024

Looks nice to me +1. It looks like the diagrams are a bit less readable in the dark mode, probably because they're transparent.

@raulb raulb added the documentation Improvements or additions to documentation label Nov 14, 2024
@raulb raulb moved this from Todo to Backlog in Conduit Main Feb 6, 2025
@raulb raulb moved this from Backlog to Todo in Conduit Main Feb 6, 2025
@raulb raulb modified the milestones: 0.14.0, Next Feb 6, 2025
@raulb raulb self-assigned this Feb 7, 2025
@raulb raulb moved this from Todo to In Progress in Conduit Main Feb 7, 2025
@raulb raulb removed their assignment Feb 10, 2025
@raulb
Copy link
Member Author

raulb commented Feb 10, 2025

Here's a branch to whoever picks it up https://github.com/ConduitIO/conduit-site/tree/enable-dark-theme.

@raulb raulb removed the status in Conduit Main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: No status
Development

No branches or pull requests

2 participants