Skip to content

Commit 8902487

Browse files
committed
Semester Based CM Reqs (#164)
1 parent 276b093 commit 8902487

File tree

6 files changed

+21
-9
lines changed

6 files changed

+21
-9
lines changed

conditional/blueprints/dashboard.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
from conditional.util.housing import get_queue_position
1919
from conditional.util.flask import render_template
20-
from conditional.util.member import get_freshman_data, get_voting_members, get_cm, get_hm
20+
from conditional.util.member import get_freshman_data, get_voting_members, get_cm, get_hm, req_cm
2121

2222
from conditional import start_of_year
2323

@@ -58,6 +58,7 @@ def display_dashboard():
5858
spring = {}
5959
c_meetings = get_cm(member)
6060
spring['committee_meetings'] = len(c_meetings)
61+
spring['req_meetings'] = req_cm(member)
6162
h_meetings = [(m.meeting_id, m.attendance_status) for m in get_hm(member)]
6263
spring['hm_missed'] = len([h for h in h_meetings if h[1] == "Absent"])
6364
eval_entry = SpringEval.query.filter(SpringEval.uid == member.uid,

conditional/blueprints/spring_evals.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
from conditional.util.flask import render_template
1313

14-
from conditional.util.member import get_cm, get_hm
14+
from conditional.util.member import get_cm, get_hm, req_cm
1515

1616
from conditional import db, start_of_year
1717

@@ -55,6 +55,7 @@ def display_spring_evals(internal=False):
5555
'uid': uid,
5656
'status': spring_entry.status,
5757
'committee_meetings': len(get_cm(account)),
58+
'req_meetings': req_cm(account),
5859
'house_meetings_missed':
5960
[
6061
{

conditional/templates/dashboard.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ <h3 class="panel-title">Membership Evaluations
127127
<tr>
128128
<td class="title">Directorship Meetings</td>
129129
<td><span class="pull-right">
130-
{% if spring['committee_meetings'] >= 25 %}
130+
{% if spring['committee_meetings'] >= spring['req_meetings'] %}
131131
<span class="glyphicon glyphicon-ok-sign green"></span> {% else %}
132-
<span class="glyphicon glyphicon-remove-sign red"></span> {% endif %} {{ spring['committee_meetings'] }} / 25</span>
132+
<span class="glyphicon glyphicon-remove-sign red"></span> {% endif %} {{ spring['committee_meetings'] }} / {{ spring['req_meetings'] }}</span>
133133
</td>
134134
</tr>
135135
<tr>

conditional/templates/spring_eval_slideshow.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<h1>{{m['name']}}</h1>
1616
<div class="row">
1717
<div class="col-xs-12 col-md-4">
18-
{% set committee_meetings_passed = m['committee_meetings'] >= 25 %}
18+
{% set committee_meetings_passed = m['committee_meetings'] >= m['req_meetings'] %}
1919
<div class="item{% if committee_meetings_passed %} passed{% endif %}" >
2020
<span class="icon glyphicon glyphicon-{% if committee_meetings_passed %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span>
2121
<h3>{{m['committee_meetings']}}</h3>

conditional/templates/spring_evals.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ <h6 class="eval-uid">{{m['uid']}}</h6>
4747
<div class="col-sm-5 col-md-6 col-lg-4">
4848
<div class="spring-info row">
4949
<div class="text-center">
50-
{% if m['committee_meetings'] < 25 %}
50+
{% if m['committee_meetings'] < m['req_meetings'] %}
5151
<div class="eval-info-label">
5252
<span class="glyphicon glyphicon-remove-sign red eval-info-status"></span>Directorship Meetings
53-
<span class="eval-info-number">{{m['committee_meetings']}} / 25</span>
53+
<span class="eval-info-number">{{m['committee_meetings']}} / {{m['req_meetings']}}</span>
5454
</div>
5555
{% else %}
5656
<div class="eval-info-label">
5757
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span>Directorship Meetings
58-
<span class="eval-info-number">{{m['committee_meetings']}} / 25</span>
58+
<span class="eval-info-number">{{m['committee_meetings']}} / {{m['req_meetings']}}</span>
5959
</div>
6060
{% endif %}
6161

@@ -208,7 +208,7 @@ <h4>Major Projects</h4>
208208
{% endif %}
209209
</td>
210210
<td>
211-
{% if m['committee_meetings'] < 25 %}
211+
{% if m['committee_meetings'] < m['req_meetings'] %}
212212
<span class="glyphicon glyphicon-remove-sign red eval-info-status"></span> {{m['committee_meetings']}}
213213
{% else %}
214214
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span> {{m['committee_meetings']}}

conditional/util/member.py

+10
Original file line numberDiff line numberDiff line change
@@ -147,3 +147,13 @@ def get_hm(member, only_absent=False):
147147
if only_absent:
148148
h_meetings = h_meetings.filter(MemberHouseMeetingAttendance.attendance_status == "Absent")
149149
return h_meetings
150+
151+
def req_cm(member):
152+
# Get the number of required committee meetings based on if the member
153+
# is going on co-op in the current operating session.
154+
co_op = CurrentCoops.query.filter(
155+
CurrentCoops.uid == member.uid,
156+
CurrentCoops.date_created > start_of_year()).first()
157+
if co_op:
158+
return 15
159+
return 30

0 commit comments

Comments
 (0)