Skip to content

The SpriteVisual should be removed from the visual tree before being disposed in AttachedShadowElementContext #816

@Ryken100

Description

@Ryken100

Describe the bug

In AttachedShadowBase.OnElementContextUninitialized() AttachedShadowElementContext.Uninitialize(), composition resources are disposed before the SpriteVisualis removed from the tree usingElementCompositionPreview.SetElementChildVisual(Element, null). We should reorder operations in these methods so that the SpriteVisual` is removed from the tree first, and then dispose of the composition reources after.

Steps to reproduce

Unable to repro locally. Internal crash telemetry points to the XAML engine accessing `CompositionObject.Properties` on a hand-in visual that has been closed but is still in the visual tree. The hand-in visual is attached to a UI element that has an `AttachedCardShadow`.

Expected behavior

If the visual is removed from the visual tree before it is closed, the system should not try to access CompositionObject.Properties on that visual, avoiding the crash.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

Min 18362, Target 26100

Visual Studio Version

No response

Visual Studio Build Number

VS 2026 18.0.0

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

Metadata

Metadata

Assignees

Labels

Priority-1bugSomething isn't workingcomponents::extensionsExtensions for text, framework components, visual transforms, shadows, and more.hotfixUsed for PRs/Issues that more immediately need review to be included in an upcoming hotfix.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions