FlashStorage.h operates with wrong page size for GD32F130

[mace-de]

GD32F130C8 has a Flash page size of 1024. FlashStorage.h operates with a page size of 4096 which messes up the commit procedure.

[maxgerhardt]

I see, so these numbers

ArduinoCore-GD32/libraries/FlashStorage/src/FlashStorage.h

Lines 43 to 56 in 0f853a9

	static constexpr uint32_t fmc_base_address = 0x08000000;
	static constexpr uint32_t bank0_size = 512 * 1024;
	static constexpr uint32_t bank0_end = fmc_base_address + bank0_size - 1;
	static constexpr uint32_t fmc_end_address = fmc_base_address + _fmc_end;
	static constexpr uint32_t data_area_start = fmc_end_address - _storage_size;
	uint16_t pageSizeForAddress(uint32_t addr)
	{
	if (addr > bank0_end)
	return 4096;
	else
	return 2048;
	}

are not universally true for all GD32 chips.

[mace-de]

For my WVC project, I use a modified Version of Flashstorage.h. It don't erase the Flash page on every commit. It fills the page with committed data until the page is full and erases the page only when there isn't enough space left. The begin function searches the last valid data block before the 0xFF filled area. This will save a lot of Flash erase cycles. Maybe this is of interest for your Lib too.