use Display instead of Debug for errors

Author: ltitanb

crates/common/src/pbs/error.rs

@@ -14,7 +14,7 @@ pub enum PbsError {
     #[error("reqwest error: {0}")]
     Reqwest(#[from] reqwest::Error),
 
-    #[error("json decode error: {err}, raw:\n{raw}")]
+    #[error("json decode error: {err}, raw: {raw}")]
     JsonDecode { err: serde_json::Error, raw: String },
 
     #[error("relay response error. Code: {code}, err: {error_msg}")]

crates/pbs/src/mev_boost/get_header.rs

@@ -85,7 +85,7 @@ pub async fn get_header<S: BuilderApiState>(
             }
             Ok(_) => {}
             Err(err) if err.is_timeout() => error!(err = "Timed Out", relay_id),
-            Err(err) => error!(?err, relay_id),
+            Err(err) => error!(%err, relay_id),
         }
     }
 
@@ -163,7 +163,7 @@ async fn send_timed_get_header(
                         }
                         Err(err) if err.is_timeout() => None,
                         Err(err) => {
-                            error!(?err, "TG: error sending header request");
+                            error!(%err, "TG: error sending header request");
                             None
                         }
                     })

crates/pbs/src/mev_boost/register_validator.rs

@@ -102,7 +102,7 @@ async fn send_register_validator(
         };
 
         // error here since we check if any success aboves
-        error!(?err, "failed registration");
+        error!(%err, "failed registration");
         return Err(err);
     };
 

crates/pbs/src/mev_boost/status.rs

@@ -84,7 +84,7 @@ async fn send_relay_check(relay: &RelayClient, headers: HeaderMap) -> Result<(),
             code: code.as_u16(),
         };
 
-        error!(?err, "status failed");
+        error!(%err, "status failed");
         return Err(err);
     };
 

crates/pbs/src/mev_boost/submit_block.rs

@@ -106,7 +106,7 @@ async fn send_submit_block(
         };
 
         // we request payload to all relays, but some may have not received it
-        warn!(?err, "failed to get payload (this might be ok if other relays have it)");
+        warn!(%err, "failed to get payload (this might be ok if other relays have it)");
         return Err(err);
     };
 

crates/pbs/src/routes/register_validator.rs

@@ -76,7 +76,7 @@ async fn send_relay_monitor_registrations(
     {
         Ok(res) => res,
         Err(err) => {
-            error!(?err, "failed monitor registration");
+            error!(%err, "failed monitor registration");
             return;
         }
     };
@@ -89,10 +89,10 @@ async fn send_relay_monitor_registrations(
                 debug!(?code, latency = ?request_latency, "relay monitor registration successful");
             } else {
                 let err = String::from_utf8_lossy(&response_bytes);
-                error!(?code, ?err, "failed monitor registration");
+                error!(?code, %err, "failed monitor registration");
             }
         }
 
-        Err(err) => error!(?err, "failed to decode monitor response"),
+        Err(err) => error!(%err, "failed to decode monitor response"),
     }
 }

crates/pbs/src/routes/submit_block.rs

@@ -63,7 +63,7 @@ pub async fn handle_submit_block<S: BuilderApiState, A: BuilderApi<S>>(
                     relays: fault_relays,
                 });
             } else {
-                error!(?err, %block_hash, "CRITICAL: no payload delivered and no relay for block hash. Was getHeader even called?");
+                error!(%err, %block_hash, "CRITICAL: no payload delivered and no relay for block hash. Was getHeader even called?");
                 state.publish_event(BuilderEvent::MissedPayload {
                     block_hash,
                     relays: String::default(),

crates/signer/src/service.rs

@@ -73,7 +73,7 @@ impl SigningService {
         let listener = TcpListener::bind(address).await.wrap_err("failed tcp binding")?;
 
         if let Err(err) = axum::serve(listener, app).await {
-            error!(?err, "Signing server exited")
+            error!(%err, "Signing server exited")
         }
         Ok(())
     }

examples/builder_log/src/main.rs

@@ -23,7 +23,7 @@ async fn main() -> eyre::Result<()> {
             let client = BuilderEventClient::new(config.server_port, LogProcessor);
 
             if let Err(err) = client.run().await {
-                error!(?err, "Service failed");
+                error!(%err, "Service failed");
             }
         }
         Err(err) => {

examples/da_commit/src/main.rs

@@ -120,7 +120,7 @@ async fn main() -> Result<()> {
             let service = DaCommitService { config };
 
             if let Err(err) = service.run().await {
-                error!(?err, "Service failed");
+                error!(%err, "Service failed");
             }
         }
         Err(err) => {