Skip to content

Commit ee3d1b5

Browse files
author
Loïc Mangeonjean
committed
fix: only keep language scoped configurationDefaults
because the other one are useless and they even make VSCode crashes if the corresponding configuration key is not registered
1 parent cd730e9 commit ee3d1b5

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

rollup.config.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ ${files.map((_, index) => ` whenReady${index}()`).join(',\n')}
153153
terminal,
154154
viewsContainers,
155155
typescriptServerPlugins,
156+
configurationDefaults,
156157
...remainingContribute
157158
} = (manifest.contributes ?? {}) as IExtensionManifest['contributes'] & {
158159
typescriptServerPlugins: unknown // typescript extension specific field
@@ -173,7 +174,15 @@ ${files.map((_, index) => ` whenReady${index}()`).join(',\n')}
173174

174175
return {
175176
...remainingManifest,
176-
contributes: remainingContribute
177+
contributes: {
178+
...remainingContribute,
179+
// Only keep scoped keys
180+
configurationDefaults: Object.fromEntries(
181+
Object.entries(configurationDefaults ?? {}).filter(
182+
([key]) => /^\[.*\]$/.exec(key) != null
183+
)
184+
)
185+
}
177186
}
178187
}
179188
}),

0 commit comments

Comments
 (0)