Simplify codebase

Author: TavoNiievez

.github/workflows/symfony.yml

@@ -3,17 +3,17 @@ name: CI
 on:
   push:
     branches:
-      - '6.4'
+      - '6.4wApi'
   pull_request:
     branches:
-      - '6.4'
+      - '6.4wApi'
 
 env:
   APP_ENV: test
 
 jobs:
   symfony:
-    name: Symfony 6.4 (PHP ${{ matrix.php-versions }})
+    name: Symfony 6.4wApi (PHP ${{ matrix.php-versions }})
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true

src/Command/ExampleCommand.php

@@ -32,13 +32,10 @@ protected function configure(): void
         );
     }
 
-    protected function initialize(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->ioStream = new SymfonyStyle($input, $output);
-    }
 
-    protected function execute(InputInterface $input, OutputInterface $output): int
-    {
         $optionSomething = $input->getOption(self::OPTION_SOMETHING);
         if ($optionSomething) {
             $this->ioStream->text('Bye world!');

src/Controller/HttpClientController.php

@@ -12,11 +12,8 @@
 
 final class HttpClientController extends AbstractController
 {
-    private HttpClientInterface $httpClient;
-
-    public function __construct(HttpClientInterface $httpClient)
+    public function __construct(private readonly HttpClientInterface $httpClient)
     {
-        $this->httpClient = $httpClient;
     }
 
     public function routeUsingHttpClient(): Response
@@ -65,9 +62,7 @@ public function routeMakingMultipleRequests(): Response
 
     public function internalEndpointPost(Request $request): Response
     {
-        $data = json_decode($request->getContent(), true);
-
-        return $this->json(['received' => $data]);
+        return $this->json(['received' => $request->toArray()]);
     }
 
     public function routeShouldNotMakeSpecificRequest(): Response

src/Controller/RegistrationController.php

@@ -19,7 +19,7 @@ final class RegistrationController extends AbstractController
     public function __construct(
         private readonly Mailer $mailer,
         private readonly UserRepositoryInterface $userRepository,
-        private readonly EventDispatcherInterface $eventDispatcher
+        private readonly EventDispatcherInterface $eventDispatcher,
     ) {
     }
 

src/Entity/User.php

@@ -40,6 +40,7 @@ public static function create(string $email, string $password, array $roles = []
         $user->email = $email;
         $user->password = $password;
         $user->roles = $roles;
+
         return $user;
     }
 

src/Repository/Model/UserRepositoryInterface.php

@@ -9,4 +9,4 @@ interface UserRepositoryInterface
     public function save(User $user): void;
 
     public function getByEmail(string $email): ?User;
-}
+}

src/Repository/UserRepository.php

@@ -27,6 +27,7 @@ public function getByEmail(string $email): ?User
     {
         /** @var User|null $user */
         $user = $this->findOneBy(['email' => $email]);
+
         return $user;
     }
 }

src/Utils/Mailer.php

@@ -9,7 +9,7 @@
 use Symfony\Component\Mailer\MailerInterface;
 use Symfony\Component\Mime\Address;
 
-final class Mailer
+final readonly class Mailer
 {
     public function __construct(private MailerInterface $mailer)
     {

tests/Functional/DoctrineCest.php

@@ -19,22 +19,22 @@ public function grabNumRecords(FunctionalTester $I)
 
     public function grabRepository(FunctionalTester $I)
     {
-        //With classes
+        // With classes
         $repository = $I->grabRepository(User::class);
         $I->assertInstanceOf(UserRepository::class, $repository);
 
-        //With Repository classes
+        // With Repository classes
         $repository = $I->grabRepository(UserRepository::class);
         $I->assertInstanceOf(UserRepository::class, $repository);
 
-        //With Entities
+        // With Entities
         $user = $I->grabEntityFromRepository(User::class, [
-            'email' => '[email protected]'
+            'email' => '[email protected]',
         ]);
         $repository = $I->grabRepository($user);
         $I->assertInstanceOf(UserRepository::class, $repository);
 
-        //With Repository interfaces
+        // With Repository interfaces
         $repository = $I->grabRepository(UserRepositoryInterface::class);
         $I->assertInstanceOf(UserRepository::class, $repository);
     }
@@ -43,5 +43,4 @@ public function seeNumRecords(FunctionalTester $I)
     {
         $I->seeNumRecords(1, User::class);
     }
-
 }

tests/Functional/EventsCest.php

@@ -93,6 +93,7 @@ public function seeEvent(FunctionalTester $I)
             $I->seeEvent('non-existent-event');
         } catch (ExpectationFailedException $ex) {
             $I->assertTrue(true, 'seeEvent assertion fails with non-existent events.');
+
             return;
         }
         $I->fail('seeEvent assertion did not fail as expected');