Added tests for IS NULL/IS NOT NULL where clauses

Author: yesdevnull

src/Codeception/Lib/Driver/Db.php

@@ -215,8 +215,8 @@ protected function generateWhereClause(array &$criteria)
         $params = [];
         foreach ($criteria as $k => $v) {
             if ($v === null) {
-                if (stripos($k, ' !=') > 0) {
-                    $params[] = $this->getQuotedName(str_ireplace(" !=", '', $k)) . " IS NOT NULL ";
+                if (strpos($k, ' !=') > 0) {
+                    $params[] = $this->getQuotedName(str_replace(" !=", '', $k)) . " IS NOT NULL ";
                 } else {
                     $params[] = $this->getQuotedName($k) . " IS NULL ";
                 }

tests/unit/Codeception/Lib/Driver/DbTest.php

@@ -23,12 +23,14 @@ public function testGenerateWhereClause($criteria, $expectedResult)
     public function getWhereCriteria()
     {
         return [
-            'like' => [['email like' => 'mail.ua'], 'WHERE "email" LIKE ? '],
-            '<='   => [['id <=' => '5'],            'WHERE "id" <= ? '],
-            '<'    => [['id <' => '5'],             'WHERE "id" < ? '],
-            '>='   => [['id >=' => '5'],            'WHERE "id" >= ? '],
-            '>'    => [['id >' => '5'],             'WHERE "id" > ? '],
-            '!='   => [['id !=' => '5'],            'WHERE "id" != ? '],
+            'like'        => [['email like' => 'mail.ua'], 'WHERE "email" LIKE ? '],
+            '<='          => [['id <=' => '5'],            'WHERE "id" <= ? '],
+            '<'           => [['id <' => '5'],             'WHERE "id" < ? '],
+            '>='          => [['id >=' => '5'],            'WHERE "id" >= ? '],
+            '>'           => [['id >' => '5'],             'WHERE "id" > ? '],
+            '!='          => [['id !=' => '5'],            'WHERE "id" != ? '],
+            'is null'     => [['id' => null],              'WHERE "id" IS NULL '],
+            'is not null' => [['id !=' => null],           'WHERE "id" IS NOT NULL '],
         ];
     }
 }