Skip to content

West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-1 |Module-Structuring-and-Testing-Data #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-1 |Module-Structuring-and-Testing-Data #663

wants to merge 23 commits into from
+215 −19

Conversation

Abayie
Copy link

@Abayie Abayie commented Jul 17, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

This pull request improves code readability and data formatting for Sprint 1 of Module-Structuring-and-Testing-Data.
I refactored programs to clearly convert and format values, such as transforming pence strings to pounds, formatting time values, and calculating percentage changes.
Each solution includes step-by-step breakdowns and explanations, ensuring the code is easy to follow and works correctly for different input cases.

Questions

Ask any questions you have for your reviewer.

@Abayie Abayie added the Needs Review Participant to add when requesting review label Jul 17, 2025
@Abayie Abayie changed the title West Midlands | ITP-May | Jonathan Boahene | Sprint-1 |Module-Structuring-and-Testing-Data West Midlands | ITP-May - 25| Jonathan Boahene | Sprint-1 |Module-Structuring-and-Testing-Data Jul 17, 2025
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 17, 2025
cjyuan
cjyuan reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation is very clear! Great job.

I just have a few questions.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025
@Abayie Abayie added the Needs Review Participant to add when requesting review label Jul 18, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 18, 2025

Changes are good! Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abayie @cjyuan