Glasgow | ITP May -25 | Pandi Simatupang | Module-Structuring-and-Testing-Data | coursework/sprint-1 #649

PandiSimatupang · 2025-07-10T12:13:12Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Provided answers and comments to Sprint-1

Questions

Null

YoanHlebarov

Overall you have a good understanding of how the code flows. Just fix the few comments!

YoanHlebarov · 2025-07-12T13:25:33Z

Sprint-1/2-mandatory-errors/1.js

 const age = 33;
+
+//reassign variable age by 1 (+1)
 age = age + 1;


That would not work as we cannot reassign variables declared with const. What other ways can you think of that can allows us to do what we want?

I wasn't aware of "const".. I need to change the variable type (to "let") so it can be reassigned.

Exactly, let would be the correct approach here. If you do not need to reassign a variable always use const. This ensures that your variable will have the information you expect it to have.

YoanHlebarov · 2025-07-12T13:29:45Z

Sprint-1/2-mandatory-errors/2.js

You should be aware of the term Hoisting, it would allow us to access variables declared with var before they are assigned. You can read more about it in the link. What you have done is the best approach, and var should be used only when absolutely necessary, but it is worth knowing more about it.

YoanHlebarov · 2025-07-12T13:33:51Z

Sprint-2/1-key-errors/2.js

Looks like you still need to answer this one!

function square(num) {
return num * num;
}

mynum = 3; //define the num
console.log(square(mynum)); //verify the result

I did that on Branch sprint-1.

Oh, OK.. outdated! No worries

I think you still need to add your prediction of what will happen if we were to run the function. Then see if there is anything that needs to be fixed, and write a new function that resolves the errors and returns the expected result!

YoanHlebarov · 2025-07-12T13:34:06Z

Sprint-2/3-mandatory-implement/1-bmi.js

Looks like you still need to answer this one!

well, interesting.. I did that on Sprint 1 branch.

I think you would need to implement the function here on this branch (which is sprint-1 too. Have you pushed all of your changes to origin?

You should implement a function that calculates BMI based off two arguments - weight and height.

YoanHlebarov · 2025-07-19T09:26:58Z

I think you still need to complete Sprint-2/1-key-errors/2.js and Sprint-2/3-mandatory-implement/1-bmi.js. If you have added the code required in another branch make sure to merge it to this one and push the changes!

Right @PandiSimatupang I noticed the issue. (sorry my bad!) These two files need to be removed as they are not related to Sprint 1!

PandiSimatupang added 26 commits July 3, 2025 00:43

add comment on the last line of file 1-count.js

3c0525b

add console.log() to verify the value of count

168186a

add function getInitial in 2-initials.js and print to verify

72645b8

solve exercise sprint1/3-paths.js

006df3d

comment and study exercise sprint-1/4-random.js

998a7ee

solve exec. sprint1/mandatory-errors/0.js

63a8de0

study exec. sprint-1/2-mandatory-errors/1.js

04cb872

solve exec. sprint-1/2-mandatory-errors/2.js

55aaa5f

solve exec. sprint-1/2-mandatory-errors/3.js

c1d3745

solve exec. sprint-1/2-mandatory-errors/4.js

a4496e3

solve exec. sprint-1/3-mandatory-interpret/1-percentage-change.js

13835fb

solve exec. sprint-1/3-mandatory-interpret/2.js

4bc0b4b

update solution 2-time-format.js

e678b92

comment out sprint-1/3-mandatory-interpret/3-to-pounds.js

a5cd1c5

tried sprint-1/4-stretch-explore/chrome.md

1f7f9e2

study and comment out sprint-1/4-mandatory-explore/objects.md

a8546b9

end of Sprit-1

65e1a8e

reset to origin file Sprint-2/1-key-errors/0.js

100b9fd

reset file Sprint-2/1-key-errors/1.js

95efc71

reset Sprint-2/1-key-errors/2.js

ce9e5c1

reset file Sprint-2/2-mandatory-debug/0.js

a638efe

reset file Sprint-2/2-mandatory-debug/1.js

5ae319d

reset file Sprint-2/2-mandatory-errors/2.js

f45625e

reset file Sprint-2/3-mandatory-implement/1-bmi.js

d8f561b

reset file Sprint-2/2-mandatory-implement/2-cases.js

08290c6

reset file Sprint-2/2-mandatory-implement/3-to-pounds.js

3bb0a7c

PandiSimatupang added the Needs Review Participant to add when requesting review label Jul 10, 2025

YoanHlebarov added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 12, 2025

YoanHlebarov reviewed Jul 12, 2025

View reviewed changes

YoanHlebarov removed the Needs Review Participant to add when requesting review label Jul 12, 2025

YoanHlebarov added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 12, 2025

change const to let Sprint-1/2-mandatory-errors/1.js

8665943

PandiSimatupang added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 16, 2025

YoanHlebarov added 👀 Review Requirements Changes requested to meet requirements 👀 Review Git Changes requested to do with Git and removed 👀 Review Requirements Changes requested to meet requirements labels Jul 19, 2025

Uh oh!

Glasgow | ITP May -25 | Pandi Simatupang | Module-Structuring-and-Testing-Data | coursework/sprint-1 #649

Are you sure you want to change the base?

Glasgow | ITP May -25 | Pandi Simatupang | Module-Structuring-and-Testing-Data | coursework/sprint-1 #649

Uh oh!

Conversation

PandiSimatupang commented Jul 10, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

YoanHlebarov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YoanHlebarov commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

YoanHlebarov commented Jul 19, 2025 •

edited

Loading