Skip to content

London|May-2025|Alexandru Pocovnicu|Coursework/sprint 2 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

London|May-2025|Alexandru Pocovnicu|Coursework/sprint 2 #514

wants to merge 19 commits into from

Conversation

alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Jun 11, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

In this PR I have fixed the errors, done the debugging, implemented functions, interpreted larger programs and wrote tests for edge cases

Questions

Ask any questions you have for your reviewer.

@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Participant to add when requesting review label Jun 11, 2025
@bodfaj13 bodfaj13 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jun 20, 2025
bodfaj13
bodfaj13 reviewed Jun 29, 2025
View reviewed changes
@bodfaj13 bodfaj13 added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 29, 2025
@alexandru-pocovnicu alexandru-pocovnicu deleted the coursework/sprint-2 branch July 1, 2025 13:12
@alexandru-pocovnicu alexandru-pocovnicu restored the coursework/sprint-2 branch July 1, 2025 13:12
@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 2, 2025
@bodfaj13 bodfaj13 added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 18, 2025
@alexandru-pocovnicu
Copy link
Author

hi @bodfaj13 , thank you for reviewing my PR, so is this complete now? i can't see any comments from you

bodfaj13
bodfaj13 suggested changes Jul 19, 2025
View reviewed changes
@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodfaj13 bodfaj13 bodfaj13 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandru-pocovnicu @bodfaj13