Skip to content

Conversation

@anosidium
Copy link

@anosidium anosidium commented Oct 3, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I’ve done what was required and also took the liberty of adding autocomplete support for browser autofill, as indicated by Chrome DevTools issues.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8c0deb2
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e03f0225164f0008c97b2d
😎 Deploy Preview https://deploy-preview-887--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@anosidium anosidium changed the title London | 25-ITP-September | Ammad Ur Rehman | Sprint 1 | 04 Form Controls London | 25-ITP-September | Ammad Ur Rehman | Sprint 2 | 04 Form Controls Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@anosidium anosidium changed the title London | 25-ITP-September | Ammad Ur Rehman | Sprint 2 | 04 Form Controls London | 25-ITP-September | Ammad Ur Rehman | Sprint 2 | Form Controls Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@super-lumic super-lumic added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2025
@super-lumic
Copy link

Looks great!

@super-lumic super-lumic added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants