Sheffield | 25-ITP-May | Hassan Osman | Quote generator App. #648
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanOHOsman
added
Needs Review
cjyuan
reviewed
Jul 19, 2025
There was a problem hiding this comment.
We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?
Note: You don't have to move your code for this. I just want to raise your awareness.
Sprint-3/quote-generator/quotes.js
Outdated
| let newQuote; | ||
| do { | ||
| newQuote = pickFromArray(quotes); | ||
| } while (newQuote === lastQuote && quotes.length > 1); |
There was a problem hiding this comment.
Nice consideration but this condition is always false.
There was a problem hiding this comment.
Simplified my code and just got rid of it altogether.
cjyuan
added
Reviewed
HassanOHOsman
added
Needs Review
cjyuan
reviewed
Jul 19, 2025
| @@ -1,3 +1,17 @@ | |||
| let lastQuote = null; | |||
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR adds functionality to display a random quote and its author on page load.
Ensures a new, different quote is shown each time the 'New Quote' button is clicked.
Questions
Ask any questions you have for your reviewer.