Sheffield|May-2025|Sheida Shabankari|Module-Data -Groups| Sprint-3|Quote generator #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Jul 17, 2025
There was a problem hiding this comment.
Code is good.
If you are interested in improving the readability of your code, you could check out the CYF's style guide: a https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/
Sprint-3/quote-generator/quotes.js
Outdated
Comment on lines
506
to
515
| document.getElementById("auto-play").addEventListener("change",(event)=>{ | ||
| if (event.target.checked){ | ||
| //console.log("auto-play is on"); | ||
| document.getElementById("auto-play-label").textContent = "auto-play : ON"; | ||
| intervalId=setInterval(pickAndDisplayQuote,5000); | ||
| }else{ | ||
| document.getElementById("auto-play-label").textContent = "auto-play : OFF"; | ||
| clearInterval(intervalId); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Can probably insert some space around operators and punctuations in the code at lines 506-511 to improve their readability (like what you did in lines 495-500).
cjyuan
added
Reviewed
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First ,I have showed qoute and author on screen by clicking the button ,next add a chekbox and if it is checked display the text automatically every 5 second and stop with uncheck ed the checkbox.
Also , I have runned the test cases and all of them passed.