WM | Abdullah Saleh | Module-Data-Groups | Sprint2

[3bdullah-saleh]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[oluwatunmiisheii]

Good job. Some minor fixes here and there, and this PR should be good to go.

[oluwatunmiisheii]

Please add the missing comments as requested - you need to include your prediction of what the code will output and explain how to fix the issue.
Solution looks good! I think you can make some minor changes to make the output look better. Consider this formatting:

console.log(`${recipe.title} serves ${recipe.serves}, the ingredients required are:
${recipe.ingredients.join("\n")}`);

[oluwatunmiisheii]

Great work on the logic; the function works correctly

Just a small improvement: please remove the console.log(countryCurrencyPairs.length) statement inside the function, as well as the console.log(createLookup([])) call at the bottom of the file.

Console logs are helpful for debugging during development, but we usually remove them from the final version of the code to keep it clean.

[oluwatunmiisheii]

You have a test.todo not implemented in this file.

The todo test is the same as the last test you have in this file. I suggest you update the description of your test and remove the test.todo

[oluwatunmiisheii]

Let's remove console.log from this file also.

[oluwatunmiisheii]

There is a missing test in this file

// Given an invalid input like a string
// When passed to tally
// Then it should throw an error

[oluwatunmiisheii]

Good work on the logic;

1. Let's remove the console.log in this file,
2. There is also a missing implementation that checks if a valid input is passed. The test for this scenario is also not implemented.

[oluwatunmiisheii]

Great work! Your logic is solid, and you've tackled the advanced challenges well.

Main issue to fix:
Your code will create empty string keys when there are multiple spaces in the input. For example, "hello world" (with two spaces) will create an empty string key in your object.

Solution:
After splitting, filter out empty strings:
const stringsIntoArray = string.replace(punctuation, "").toLowerCase().split(" ").filter(word => word !== "");

[oluwatunmiisheii]

Good work on the refactoring! Can you remove the console.log line?

[oluwatunmiisheii]

Nice work! Just a small fix needed - change coin.slice("0", coin.length - 1) to coin.slice(0, coin.length - 1). The first argument needs to be a number, not a string.
Here's the MDN reference if helpful: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/slice"