GLASGOW | May-2025 | Taras Mykytiuk | Module-Data-Groups | Sprint_3 | Alarm_Clock #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoanHlebarov
added
the
Review in progress
|
That is a good stab at the problem at hand. Overall the approach is good and you are very close to getting a good working solution. See if you can fix the bug I pointed above. Another thing to consider if you should be using |
YoanHlebarov
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Changed files: alarmcklock.js and index.html.
Web page now has alarm clock with timer.
Questions
Ask any questions you have for your reviewer.