London | ITP MAY | Jamal Laqdiem | Module Data Groups | Sprint-2 #588
Conversation
jemaljemy
added
Needs Review
AdnanGondal
added
the
Review in progress
| //test 1: | ||
| const result1 = invert({a:1}); | ||
| const expected1 = {1:'a'}; | ||
| console.log(`Test 1: Input {a:1}, Expected ${JSON.stringify(expected1)}, Actual ${JSON.stringify(result1)}`); |
There was a problem hiding this comment.
Why did you use JSON.stringify() here? What does it do and what benefit does it provide?
There was a problem hiding this comment.
Thanks for reviewing, I used JSON.stringify() for readability and consistency, which it make it easy to read, compare and copy-paste.
Sprint-2/implement/contains.js
Outdated
|
|
||
| } | ||
|
|
||
| console.log(contains({first_name :'john'}, 'first_name')) |
There was a problem hiding this comment.
Since you have all of these test cases inside your contains.test.js folder, wouldn't it be cleaner to remove all the console.log lines in this file?
There was a problem hiding this comment.
Thanks for reviewing, yes you are right, i will remove them.
| }); | ||
| }); | ||
|
|
||
| test("ignores empty key-value pairs created by multiple '&'", () => { |
There was a problem hiding this comment.
Can you add an extra line to this test to check:
expect(Object.keys(result)).not.toContain("");
Let me know what happens, and why so?
There was a problem hiding this comment.
Thanks for reviewing, It ensures that the object keys are properly formed and don't contain empty or invalid name,and preventing empty string keys, and make the test more robust.
| throw new Error ('Error parameter must be an array.') | ||
| } | ||
| for(count of arr) { | ||
| objectResult[count]= (objectResult[count] || 0) +1 ; |
AdnanGondal
added
Reviewed
Learners, PR Template
Self checklist
Changelist
This pull request addresses several bug fixes and introduces new functionalities within the Module-Data-Groups . The changes include improvements to existing exercises and the implementation of new core functions.
Questions
Ask any questions you have for your reviewer.