London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 2 #578

sedazam · 2025-07-10T22:52:22Z

You must title your PR like this:

REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME

For example,

London | May-2025 | Carol Owen | Quote-generator

Complete the task list below this message.
If your PR is rejected, check the task list.

-->

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

This pull request includes debugging fixes, implementation improvements, and testing updates across multiple files in Sprint-2 and Sprint-3. Key changes include resolving bugs in object property handling, enhancing functionality for utility functions, and adding comprehensive test cases to ensure correctness. Below is a categorized summary of the most important changes:

Debugging Fixes:

address.js: Fixed a bug where address.houseNumber was incorrectly accessed as address[0]. Updated the code to properly define the address object and access its properties. [1] [2]
author.js: Corrected the iteration over object properties by replacing for...of with Object.values() to handle non-iterable objects. [1] [2]
recipe.js: Adjusted the logging of recipe ingredients by iterating over the array and joining them with newlines for proper formatting. [1] [2]

Implementation Enhancements:

contains.js: Implemented the contains function to check for object properties with safety checks for invalid inputs.
lookup.js: Added the createLookup function to generate a key-value mapping from an array of pairs.
querystring.js: Fixed edge cases in parseQueryString, such as handling keys without values, and updated the test suite. [1] [2]
tally.js: Implemented the tally function to count occurrences of items in an array, with error handling for invalid inputs. [1] [2]
invert.js: Corrected the invert function to dynamically swap object keys and values and added explanatory comments.

Testing Improvements:

contains.test.js: Added comprehensive tests for the contains function, covering valid and invalid inputs, empty objects, and edge cases.
lookup.test.js: Added a test for createLookup to validate the output structure and correctness.
tally.test.js: Expanded test coverage for the tally function, including cases for empty arrays, duplicate items, and invalid inputs.

Stretch Goals:

count-words.js: Implemented a function to count word occurrences in a string, including handling empty or whitespace-only strings.
mode.js: Refactored calculateMode by splitting it into smaller functions for frequency calculation and finding the most frequent value. [1] [2]
till.js: Fixed and added an alternative implementation for totalTill to correctly calculate total amounts in pounds, with detailed explanations and tests. [1] [2]

Questions

Ask any questions you have for your reviewer.

created new file called mean.test.js: prep/mean.test.js created new file called mean.js

deleted: prep/mean.test.js

…t-2/debug/address.js

…e.js

modified: Sprint-2/implement/contains.test.js deleted: Sprint-2/package-lock.json deleted: Sprint-2/package.json

deleted: Sprint-3/package.json

modified: Sprint-2/implement/lookup.test.js

…uerystring.js modified: Added test to check the new function Sprint-2/implement/querystring.test.js

modified: Sprint-2/implement/tally.test.js

…nd getMostFrequentValue for improved readability and maintainability

…by converting coin strings to numbers

The package.json file was mistakenly changed.

cjyuan

Code is good. Good job! I manly have some suggestions.

Sprint-2/implement/contains.js

Sprint-2/implement/lookup.test.js

cjyuan · 2025-07-19T14:33:54Z

Sprint-2/implement/querystring.js

+      queryParams[pair] = "";
+    } else {
+      const key = pair.slice(0, firstEqualIndex);
+      const value = pair.slice(firstEqualIndex + 1);
+      queryParams[key] = value;


Please note that in real querystring, both key and value are percent-encoded or URL encoded in the URL. For example, the string "5%" will be encoded as "5%25". So to get the actual value of "5%25" (whether it is a key or value in the querystring), you should call a function to decode it.
May I suggest looking up any of these terms, and "How to decode URL encoded string in JS"?

Character Encoded As Reason

% %25 Starts an encoded sequence, must be escaped itself

(space) %20 Spaces are not allowed in URLs

& %26 Separates query parameters

= %3D Assigns values to keys

? %3F Starts a query string

! %21 Reserved character, often escaped

/ %2F Used in paths, escaped in values

# %23 Starts a URL fragment

" %22 Double quotes must be escaped

' %27 Single quotes can cause parsing issues

: %3A Used in protocols (e.g., http:)

+ %2B May be interpreted as space in form data

There are built-in functions you can use to decode the percent-encoded key and value at lines 14 and 18.

Sprint-2/implement/tally.test.js

Sprint-2/stretch/count-words.js

Sprint-2/stretch/till.js

…ization

… insensitivity

…ed output in tests

…unrecognized coins

…calculation

sedazam · 2025-07-19T23:54:47Z

Merge branch 'main' into Sprint-2

What happened here?

cjyuan

Changes look good.
Additional changes are optional. I will mark this PR as complete first.
You are seeing this probably because you have recently included the latest commit made on CYF's main.

cjyuan · 2025-07-20T13:10:53Z

Sprint-2/stretch/till.js

+const coinValues = {
  "1p": 10,
  "5p": 6,
  "50p": 4,
  "20p": 10,
 };
-const totalAmount = totalTill(till);
+


The variable at line 34 should be kept as till. The property values represent the number of coins.

The coinValues to be used as a lookup table is supposed to represent the value of each coin.
And since the lookup table is used locally within the function, you can write

function totalTillAlternative(till) { const coinValues = { "1p": 1, "5p": 5, "50p": 50, "20p": 20, }; let total = 0; // Code to calculate total ... return `£${(total / 100).toFixed(2)}`; }

cjyuan · 2025-07-20T13:17:31Z

Sprint-2/stretch/till.js

+function totalTillAlternative(till) {
+  let total = 0;
+
+  for (const [coin, quantity] of Object.entries(till)) {
+    // Convert coin to a number and multiply by quantity
+    total += coinValues[coin] * quantity;
+
+  if (!coin in coinValues) {
+      throw new Error(`Coin ${coin} is not recognized`);
+    }
+
+  return `£${(total / 100).toFixed(2)}`;
+}


You didn't have to delete your original implementation, you could just implement a new function.

Anyway, this totalTillAlternative() is similar to totalTill() (why keep two similar copies?), and it has a bug.

cjyuan · 2025-07-20T13:19:35Z

Sprint-2/implement/querystring.js

+      queryParams[pair] = "";
+    } else {
+      const key = pair.slice(0, firstEqualIndex);
+      const value = pair.slice(firstEqualIndex + 1);
+      queryParams[key] = value;


There are built-in functions you can use to decode the percent-encoded key and value at lines 14 and 18.

sedazam and others added 22 commits June 28, 2025 15:34

created new prep directory: prep/mean.js

34a63f3

created new file called mean.test.js: prep/mean.test.js created new file called mean.js

modified: prep/mean.js

54c512a

deleted: prep/mean.js

21cada7

deleted: prep/mean.test.js

modified: removed [0] and replaced it with address.houseNumber Sprin…

e2e39ca

…t-2/debug/address.js

modified: changed author.values[author] Sprint-2/debug/author.js

fc5ec4a

modified: changed recipe.ingredients.join("\n") Sprint-2/debug/recip…

05faf71

…e.js

modified: Added comments to Sprint-2/debug/address.js

f6fee7b

modified: Changed the Object.values() Sprint-2/debug/author.js

12d95e5

modified: Sprint-2/implement/contains.js

d6f0baf

modified: Sprint-2/implement/contains.test.js deleted: Sprint-2/package-lock.json deleted: Sprint-2/package.json

new file: Sprint-2/package.json

fd6ad45

modified: Sprint-3/package.json

282676a

deleted: Sprint-3/package.json

modified: Sprint-2/implement/contains.js

330f67a

Merge branch 'CodeYourFuture:main' into Sprint-2

fd4ba76

75cdab9

modified: Sprint-2/implement/lookup.js

0da6bcb

modified: Sprint-2/implement/lookup.test.js

modified: Sprint-2/implement/lookup.js

fc94a75

modified: Sprint-2/implement/lookup.test.js

modified: Fixed to handle values without = sign Sprint-2/implement/q…

1df5c85

…uerystring.js modified: Added test to check the new function Sprint-2/implement/querystring.test.js

modified: Sprint-2/implement/tally.js

83e6497

modified: Sprint-2/implement/tally.test.js

Fix invert function to correctly swap keys and values in the object

1f5ee6f

Implement countWords function to count word occurrences in a string

3d6bdf4

Refactor calculateMode function by splitting it into getFrequencies a…

2e3464a

…nd getMostFrequentValue for improved readability and maintainability

Fix totalTill function to correctly calculate total amount in pounds …

f9a944e

…by converting coin strings to numbers

sedazam marked this pull request as ready for review July 10, 2025 22:53

sedazam added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review labels Jul 10, 2025

sedazam added 5 commits July 11, 2025 00:03

undo changes to Sprint 3 package.json file

1734c42

The package.json file was mistakenly changed.

undo the changes to package.json file

4619e3d

undo changes to package.json file

ca5f265

Update package.json

8b4abbd

Update package.json

2be54ee

Implement feature X to enhance user experience and fix bug Y in module Z

afbdad0

cjyuan reviewed Jul 19, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 19, 2025

sedazam added 8 commits July 19, 2025 21:56

Refactor contains function for improved input validation

bee93a4

Refactor test syntax for consistency and clarity

ab5f179

Refactor tally function to use Object.create(null) for result initial…

f865aa4

…ization

Refactor countWords function for improved readability and efficiency

b924a9f

Refactor countWords function to improve punctuation handling and case…

e893a83

… insensitivity

Fix totalTill function to return formatted currency and update expect…

2a152c6

…ed output in tests

Fix totalTill function to correctly calculate total value and handle …

61584ba

…unrecognized coins

Fix totalTill function to handle unrecognized coins and update total …

4213201

…calculation

sedazam added the Needs Review Participant to add when requesting review label Jul 19, 2025

sedazam force-pushed the Sprint-2 branch from 7041e08 to 4213201 Compare July 19, 2025 23:35

Merge branch 'main' into Sprint-2

a2a063e

cjyuan reviewed Jul 20, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 2 #578

London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 2 #578

sedazam commented Jul 10, 2025 •

edited

Loading

Uh oh!

cjyuan left a comment

Uh oh!

Uh oh!

Uh oh!

cjyuan Jul 19, 2025

Uh oh!

sedazam Jul 19, 2025

Uh oh!

cjyuan Jul 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sedazam commented Jul 19, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jul 20, 2025

Uh oh!

cjyuan Jul 20, 2025

Uh oh!

cjyuan Jul 20, 2025

Uh oh!

Uh oh!

Character	Encoded As	Reason
`%`	`%25`	Starts an encoded sequence, must be escaped itself
(space)	`%20`	Spaces are not allowed in URLs
`&`	`%26`	Separates query parameters
`=`	`%3D`	Assigns values to keys
`?`	`%3F`	Starts a query string
`!`	`%21`	Reserved character, often escaped
`/`	`%2F`	Used in paths, escaped in values
`#`	`%23`	Starts a URL fragment
`"`	`%22`	Double quotes must be escaped
`'`	`%27`	Single quotes can cause parsing issues
`:`	`%3A`	Used in protocols (e.g., `http:`)
`+`	`%2B`	May be interpreted as space in form data

Uh oh!

London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 2 #578

Are you sure you want to change the base?

London | ITP-May-2025 | Seddiq Azam | Module-Data-Groups | Sprint 2 #578

Conversation

sedazam commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Debugging Fixes:

Implementation Enhancements:

Testing Improvements:

Stretch Goals:

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjyuan Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

sedazam Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sedazam commented Jul 19, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sedazam commented Jul 10, 2025 •

edited

Loading