GLASGOW | May-2025 | Taras Mykytiuk | Module-Data-Flows | Sprint_1 #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarasMykytiuk
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 30, 2025
| @@ -6,7 +6,10 @@ const personOne = { | |||
|
|
|||
| // Update the parameter to this function to make it work. | |||
| // Don't change anything else. | |||
| function introduceYourself(___________________________) { | |||
| function introduceYourself(person) { | |||
There was a problem hiding this comment.
The goal in this task is to use object destructuring to solve the challenge. Can you see how to change only the parameter here (person) such that the original function works?
Hint: Don't create new variables, like accessing person.name.
| @@ -70,3 +70,24 @@ let hogwarts = [ | |||
| occupation: "Teacher", | |||
| }, | |||
| ]; | |||
|
|
|||
| function displayGryffindor(hogwarts) { | |||
| for (const person of hogwarts) { | |||
There was a problem hiding this comment.
Similar comment to task 1 - instead of getting a person and then accessing a property like .house, can you use object destructuring in the for-of loop?
| } | ||
|
|
||
| // number of digits can be calculated from logarithm with base 10 | ||
| function numberDigitsQuantity(number) { |
There was a problem hiding this comment.
You may be overthinking this task - we don't need something that is absolutely perfectly formatted, rather we are trying to build a function that can incorporate object destructuring to avoid having to keep accessing properties on the objects
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
All exercises from sprint 1 done.
Questions
Ask any questions you have for your reviewer.