Skip to content

Commit 3079e9a

Browse files
authored
release : fix windows hip release (ggml-org#13707)
* release : fix windows hip release * make single hip release with multiple targets
1 parent 8a1d206 commit 3079e9a

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

.github/workflows/release.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,7 @@ jobs:
448448
WINDOWS_BASEKIT_URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7cd9bba0-7aab-4e30-b3ae-2221006a4a05/intel-oneapi-base-toolkit-2025.1.1.34_offline.exe
449449
WINDOWS_DPCPP_MKL: intel.oneapi.win.cpp-dpcpp-common:intel.oneapi.win.mkl.devel:intel.oneapi.win.dnnl:intel.oneapi.win.tbb.devel
450450
ONEAPI_ROOT: "C:/Program Files (x86)/Intel/oneAPI"
451+
451452
steps:
452453
- name: Clone
453454
id: checkout
@@ -513,7 +514,9 @@ jobs:
513514

514515
strategy:
515516
matrix:
516-
gpu_target: [gfx1100, gfx1101, gfx1030]
517+
include:
518+
- name: "radeon"
519+
gpu_targets: "gfx1100;gfx1101;gfx1102;gfx1030;gfx1031;gfx1032"
517520

518521
steps:
519522
- name: Clone
@@ -528,7 +531,7 @@ jobs:
528531
- name: ccache
529532
uses: hendrikmuhs/[email protected]
530533
with:
531-
key: windows-latest-cmake-hip-${{ matrix.gpu_target }}-x64
534+
key: windows-latest-cmake-hip-${{ matrix.name }}-x64
532535
evict-old-files: 1d
533536

534537
- name: Install
@@ -554,9 +557,12 @@ jobs:
554557
cmake -G "Unix Makefiles" -B build -S . `
555558
-DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" `
556559
-DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" `
557-
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/rocwmma/library/include/" `
560+
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/rocwmma/library/include/ -Wno-ignored-attributes -Wno-nested-anon-types" `
558561
-DCMAKE_BUILD_TYPE=Release `
559-
-DAMDGPU_TARGETS=${{ matrix.gpu_target }} `
562+
-DGGML_BACKEND_DL=ON `
563+
-DGGML_NATIVE=OFF `
564+
-DGGML_CPU=OFF `
565+
-DAMDGPU_TARGETS="${{ matrix.gpu_targets }}" `
560566
-DGGML_HIP_ROCWMMA_FATTN=ON `
561567
-DGGML_HIP=ON `
562568
-DLLAMA_CURL=OFF
@@ -569,13 +575,13 @@ jobs:
569575
- name: Pack artifacts
570576
id: pack_artifacts
571577
run: |
572-
7z a llama-bin-win-hip-${{ matrix.gpu_target }}-x64.zip .\build\bin\*
578+
7z a llama-bin-win-hip-${{ matrix.name }}-x64.zip .\build\bin\*
573579
574580
- name: Upload artifacts
575581
uses: actions/upload-artifact@v4
576582
with:
577-
path: llama-bin-win-hip-${{ matrix.gpu_target }}-x64.zip
578-
name: llama-bin-win-hip-${{ matrix.gpu_target }}-x64.zip
583+
path: llama-bin-win-hip-${{ matrix.name }}-x64.zip
584+
name: llama-bin-win-hip-${{ matrix.name }}-x64.zip
579585

580586
ios-xcode-build:
581587
runs-on: macos-latest

0 commit comments

Comments
 (0)