mctp-client: fix valid_parse usage

We have a potentially uninit variable here:

    ../src/mctp-client.c: In function ‘main’:
    ../src/mctp-client.c:212:14: warning: ‘valid_parse’ may be used uninitialized [-Wmaybe-uninitialized]
      212 |         bool valid_parse, valid_eid, valid_type;
          |              ^~~~~~~~~~~

The valid_parse variable is only initialised in the argument iterator,
so checking outside of this loop may miss cases where a subsequent
argument resets it.

Instead, error-out in the same iteration as an invalid parse.

Signed-off-by: Jeremy Kerr <[email protected]>

Author: jk-ozlabs

src/mctp-client.c

@@ -209,8 +209,8 @@ static int find_data(int argc, char **argv)
 
 int main(int argc, char **argv)
 {
-	bool valid_parse, valid_eid, valid_type;
 	int ctr, data_idx, net = MCTP_NET_ANY;
+	bool valid_eid, valid_type;
 	struct data_t send_data;
 	char *tag, *endp, *val;
 	unsigned long int tmp;
@@ -235,6 +235,8 @@ int main(int argc, char **argv)
 	valid_type = false;
 
 	for (ctr = 1; ctr < argc; ctr += 2) {
+		bool valid_parse;
+
 		tag = argv[ctr];
 		val = argv[ctr + 1];
 		tmp = strtoul(val, &endp, 0);
@@ -257,9 +259,12 @@ int main(int argc, char **argv)
 			valid_type = true;
 		} else
 			errx(EXIT_FAILURE, "invalid tag: %s", tag);
+
+		if (!valid_parse)
+			errx(EXIT_FAILURE, "invalid argument: %s", val);
 	}
 
-	if (!valid_parse || !valid_eid || !valid_type) {
+	if (!valid_eid || !valid_type) {
 		print_usage();
 		return EXIT_FAILURE;
 	}