Skip to content

Commit f0737be

Browse files
captainsafiacaptainsafia
authored
Update docs to clarify feedback from dotnet#37240 (dotnet#44212)
1 parent 77130ba commit f0737be

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

‎docs/BuildFromSource.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ The experience for building the repo is slightly different based on what environ
3434
Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser
3535
```
3636
37-
2. In order to install Visual Studio on your machine, you can use the official installer script in the repo. Even if you have the appropriate Visual Studio installed on your machine, we recommend running this installation script so that the correct components are installed.
37+
2. In order to install Visual Studio on your machine, you can use the official installer script in the repo.
38+
39+
> ⚠️ Even if you have the appropriate Visual Studio installed on your machine, we recommend running this installation script so that the correct Visual Studio components are installed.
3840
3941
```powershell
4042
./eng/scripts/InstallVisualStudio.ps1
@@ -184,12 +186,12 @@ To support building and testing all the projects in the repo, various dependenci
184186
185187
### Optional Dependencies
186188
187-
| Dependency | Use |
188-
| ------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------- |
189-
| [Selenium](https://www.selenium.dev/) | Used to run integration tests in the `Components` (aka Blazor) project. |
190-
| [Playwright](https://playwright.dev/) | Used to run template tests defined in the `ProjectTemplates` work. |
191-
| [Chrome](https://www.google.com/chrome/) | Required when running tests with Selenium or Playwright in the projects above. When using Playwright, the dependency is automatically installed. |
192-
| [Java Development Kit (v11 or newer)](https://jdk.java.net/) | Required when building the Java SignalR client. Can be installed using the `./eng/scripts/InstallJdk.ps1` script on Windows. |
193-
| [Wix](https://wixtoolset.org/releases/) | Required when working with the Windows installers in the [Windows installers project](https://github.com/dotnet/aspnetcore/tree/main/src/Installers/Windows). |
194-
| [NodeJS](https://nodejs.org/en/) | Used for building JavaScript assets in the repo, such as those in Blazor and SignalR. |
195-
| [Yarn](https://yarnpkg.com/) | Used for installing JavaScript dependencies in the repo, such as those in Blazor and SignalR. |
189+
| Dependency | Use | Notes |
190+
| ------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------- |
191+
| [Selenium](https://www.selenium.dev/) | Used to run integration tests in the `Components` (aka Blazor) project. | |
192+
| [Playwright](https://playwright.dev/) | Used to run template tests defined in the `ProjectTemplates` work. | |
193+
| [Chrome](https://www.google.com/chrome/) | Required when running tests with Selenium or Playwright in the projects above. When using Playwright, the dependency is automatically installed. | |
194+
| [Java Development Kit (v11 or newer)](https://jdk.java.net/) | Required when building the Java SignalR client. Can be installed using the `./eng/scripts/InstallJdk.ps1` script on Windows. | Ensure that the `JAVA_HOME` directory points to the installation and that the `PATH` has been updated to include the `$(jdkInstallDir)/bin` folder. |
195+
| [Wix](https://wixtoolset.org/releases/) | Required when working with the Windows installers in the [Windows installers project](https://github.com/dotnet/aspnetcore/tree/main/src/Installers/Windows). | |
196+
| [NodeJS](https://nodejs.org/en/) | Used for building JavaScript assets in the repo, such as those in Blazor and SignalR. | Required a minimum version of the current NodeJS LTS. |
197+
| [Yarn](https://yarnpkg.com/) | Used for installing JavaScript dependencies in the repo, such as those in Blazor and SignalR. | |

0 commit comments

Comments
 (0)