Update @types/Webpack (dotnet#45211)

BrennanConroy · web-flow · commit 37c338e278a5 · 2022-11-22T09:56:44.000-08:00
diff --git a/src/SignalR/clients/ts/FunctionalTests/ts/HubConnectionTests.ts b/src/SignalR/clients/ts/FunctionalTests/ts/HubConnectionTests.ts
@@ -198,7 +198,7 @@ describe("hubConnection", () => {
                     // exception expected but none thrown
                     fail();
                 } catch (e) {
-                    expect(e.message).toBe(errorMessage);
+                    expect((e as any).message).toBe(errorMessage);
                 }
 
                 await hubConnection.stop();
@@ -216,7 +216,7 @@ describe("hubConnection", () => {
                     // exception expected but none thrown
                     fail();
                 } catch (e) {
-                    expect(e.message).toBe("The client attempted to invoke the streaming 'EmptyStream' method with a non-streaming invocation.");
+                    expect((e as any).message).toBe("The client attempted to invoke the streaming 'EmptyStream' method with a non-streaming invocation.");
                 }
 
                 await hubConnection.stop();
@@ -234,7 +234,7 @@ describe("hubConnection", () => {
                     // exception expected but none thrown
                     fail();
                 } catch (e) {
-                    expect(e.message).toBe("The client attempted to invoke the streaming 'Stream' method with a non-streaming invocation.");
+                    expect((e as any).message).toBe("The client attempted to invoke the streaming 'Stream' method with a non-streaming invocation.");
                 }
 
                 await hubConnection.stop();
@@ -377,12 +377,12 @@ describe("hubConnection", () => {
                 try {
                     await hubConnection.start();
                 } catch (error) {
-                    if (error!.message.includes("404")) {
+                    if ((error as any)!.message.includes("404")) {
                         // SSE can race with the connection closing and the initial ping being successful or failing with a 404.
                         // LongPolling doesn't have pings and WebSockets is a synchronous API over a single HTTP request so it doesn't have the same issues
-                        expect(error!.message).toEqual("No Connection with that ID: Status code '404'");
+                        expect((error as any)!.message).toEqual("No Connection with that ID: Status code '404'");
                     } else {
-                        expect(error!.message).toEqual(expectedErrorMessage);
+                        expect((error as any)!.message).toEqual(expectedErrorMessage);
                     }
                     closePromise.resolve();
                 }
@@ -515,7 +515,7 @@ describe("hubConnection", () => {
                     await resultPromise;
                     expect(false).toBe(true);
                 } catch (err) {
-                    expect(err.message).toEqual("An unexpected error occurred invoking 'StreamingConcat' on the server. Exception: Something bad");
+                    expect((err as any).message).toEqual("An unexpected error occurred invoking 'StreamingConcat' on the server. Exception: Something bad");
                 } finally {
                     await hubConnection.stop();
                 }
diff --git a/src/SignalR/clients/ts/common/package.json b/src/SignalR/clients/ts/common/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@types/jest": "^26.0.20",
     "@types/node": "^14.14.31",
-    "@types/webpack": "^4.41.26",
+    "@types/webpack": "^5.28.0",
     "@typescript-eslint/eslint-plugin": "^5.26.0",
     "@typescript-eslint/parser": "^5.26.0",
     "eslint": "^8.16.0",
diff --git a/src/SignalR/clients/ts/common/yarn.lock b/src/SignalR/clients/ts/common/yarn.lock
diff --git a/src/SignalR/clients/ts/signalr/src/HttpConnection.ts b/src/SignalR/clients/ts/signalr/src/HttpConnection.ts
@@ -434,7 +434,7 @@ export class HttpConnection implements IConnection {
         return this.transport!.connect(url, transferFormat);
     }
 
-    private _resolveTransportOrError(endpoint: IAvailableTransport, requestedTransport: HttpTransportType | undefined, requestedTransferFormat: TransferFormat): ITransport | Error {
+    private _resolveTransportOrError(endpoint: IAvailableTransport, requestedTransport: HttpTransportType | undefined, requestedTransferFormat: TransferFormat): ITransport | Error | unknown {
         const transport = HttpTransportType[endpoint.transport];
         if (transport === null || transport === undefined) {
             this._logger.log(LogLevel.Debug, `Skipping transport '${endpoint.transport}' because it is not supported by this client.`);
diff --git a/src/SignalR/clients/ts/signalr/src/HubConnection.ts b/src/SignalR/clients/ts/signalr/src/HubConnection.ts
@@ -862,7 +862,7 @@ export class HubConnection {
                     return;
                 }
 
-                retryError = e instanceof Error ? e : new Error(e.toString());
+                retryError = e instanceof Error ? e : new Error((e as any).toString());
                 nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts++, Date.now() - reconnectStartTime, retryError);
             }
         }
diff --git a/src/SignalR/clients/ts/signalr/src/IConnection.ts b/src/SignalR/clients/ts/signalr/src/IConnection.ts
@@ -12,7 +12,7 @@ export interface IConnection {
 
     start(transferFormat: TransferFormat): Promise<void>;
     send(data: string | ArrayBuffer): Promise<void>;
-    stop(error?: Error): Promise<void>;
+    stop(error?: Error | unknown): Promise<void>;
 
     onreceive: ((data: string | ArrayBuffer) => void) | null;
     onclose: ((error?: Error) => void) | null;
diff --git a/src/SignalR/clients/ts/signalr/src/LongPollingTransport.ts b/src/SignalR/clients/ts/signalr/src/LongPollingTransport.ts
@@ -20,10 +20,10 @@ export class LongPollingTransport implements ITransport {
     private _url?: string;
     private _running: boolean;
     private _receiving?: Promise<void>;
-    private _closeError?: Error;
+    private _closeError?: Error | unknown;
 
     public onreceive: ((data: string | ArrayBuffer) => void) | null;
-    public onclose: ((error?: Error) => void) | null;
+    public onclose: ((error?: Error | unknown) => void) | null;
 
     // This is an internal type, not exported from 'index' so this is really just internal.
     public get pollAborted(): boolean {
@@ -122,7 +122,7 @@ export class LongPollingTransport implements ITransport {
                 } catch (e) {
                     if (!this._running) {
                         // Log but disregard errors that occur after stopping
-                        this._logger.log(LogLevel.Trace, `(LongPolling transport) Poll errored after shutdown: ${e.message}`);
+                        this._logger.log(LogLevel.Trace, `(LongPolling transport) Poll errored after shutdown: ${(e as any).message}`);
                     } else {
                         if (e instanceof TimeoutError) {
                             // Ignore timeouts and reissue the poll.
diff --git a/src/SignalR/clients/ts/signalr/src/ServerSentEventsTransport.ts b/src/SignalR/clients/ts/signalr/src/ServerSentEventsTransport.ts
@@ -18,7 +18,7 @@ export class ServerSentEventsTransport implements ITransport {
     private _url?: string;
 
     public onreceive: ((data: string | ArrayBuffer) => void) | null;
-    public onclose: ((error?: Error) => void) | null;
+    public onclose: ((error?: Error | unknown) => void) | null;
 
     constructor(httpClient: HttpClient, accessToken: string | undefined, logger: ILogger,
                 options: IHttpConnectionOptions) {
@@ -116,7 +116,7 @@ export class ServerSentEventsTransport implements ITransport {
         return Promise.resolve();
     }
 
-    private _close(e?: Error) {
+    private _close(e?: Error | unknown) {
         if (this._eventSource) {
             this._eventSource.close();
             this._eventSource = undefined;
diff --git a/src/SignalR/clients/ts/signalr/src/WebSocketTransport.ts b/src/SignalR/clients/ts/signalr/src/WebSocketTransport.ts
@@ -159,7 +159,7 @@ export class WebSocketTransport implements ITransport {
         return Promise.resolve();
     }
 
-    private _close(event?: CloseEvent | Error): void {
+    private _close(event?: CloseEvent | Error | unknown): void {
         // webSocket will be null if the transport did not start successfully
         if (this._webSocket) {
             // Clear websocket handlers because we are considering the socket closed now
diff --git a/src/SignalR/clients/ts/signalr/tests/HttpConnection.test.ts b/src/SignalR/clients/ts/signalr/tests/HttpConnection.test.ts
@@ -483,7 +483,7 @@ describe("HttpConnection", () => {
                     await connection.start(TransferFormat.Text);
                     fail("Expected connection.start to throw!");
                 } catch (e) {
-                    expect(e.message).toBe(`Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);
+                    expect((e as any).message).toBe(`Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);
                 }
             },
             `Failed to start the connection: Error: Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);
diff --git a/src/SignalR/clients/ts/signalr/tests/ServerSentEventsTransport.test.ts b/src/SignalR/clients/ts/signalr/tests/ServerSentEventsTransport.test.ts
@@ -1,10 +1,9 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-import { MessageHeaders } from "../src/IHubProtocol";
 import { TransferFormat } from "../src/ITransport";
 
-import { HttpClient, HttpRequest, HttpResponse } from "../src/HttpClient";
+import { HttpRequest, HttpResponse } from "../src/HttpClient";
 import { ILogger } from "../src/ILogger";
 import { ServerSentEventsTransport } from "../src/ServerSentEventsTransport";
 import { getUserAgentHeader } from "../src/Utils";
@@ -186,7 +185,7 @@ describe("ServerSentEventsTransport", () => {
             const sse = await createAndStartSSE(logger);
 
             let closeCalled: boolean = false;
-            let error: Error | undefined;
+            let error: Error | unknown;
             sse.onclose = (e) => {
                 closeCalled = true;
                 error = e;
@@ -222,7 +221,7 @@ describe("ServerSentEventsTransport", () => {
             };
 
             let closeCalled: boolean = false;
-            let error: Error | undefined;
+            let error: Error | unknown;
             sse.onclose = (e) => {
                 closeCalled = true;
                 error = e;
diff --git a/src/SignalR/clients/ts/signalr/tests/TestEventSource.ts b/src/SignalR/clients/ts/signalr/tests/TestEventSource.ts
@@ -39,19 +39,26 @@ export class TestEventSource implements EventSource {
             TestEventSource.eventSourceSet.resolve();
         }
     }
+    addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions | undefined): void;
+    addEventListener(type: string, listener: (this: EventSource, event // The .NET Foundation licenses this file to you under the MIT license.
+        : MessageEvent<any>) => any, options?: boolean | AddEventListenerOptions | undefined): void;
+    addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions | undefined): void;
+    addEventListener(type: unknown, listener: unknown, options?: unknown): void {
+        throw new Error("Method not implemented.");
+    }
+    removeEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | EventListenerOptions | undefined): void;
+    removeEventListener(type: string, listener: (this: EventSource, event: MessageEvent<any>) => any, options?: boolean | EventListenerOptions | undefined): void;
+    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions | undefined): void;
+    removeEventListener(type: unknown, listener: unknown, options?: unknown): void {
+        throw new Error("Method not implemented.");
+    }
 
     public close(): void {
         this.closed = true;
     }
-    public addEventListener(type: string, listener?: EventListener | EventListenerObject | null, options?: boolean | AddEventListenerOptions): void {
-        throw new Error("Method not implemented.");
-    }
     public dispatchEvent(evt: Event): boolean {
         throw new Error("Method not implemented.");
     }
-    public removeEventListener(type: string, listener?: EventListener | EventListenerObject | null, options?: boolean | EventListenerOptions): void {
-        throw new Error("Method not implemented.");
-    }
 
     public static callOnOpen(): void {
     }
diff --git a/src/SignalR/clients/ts/signalr/tests/TestWebSocket.ts b/src/SignalR/clients/ts/signalr/tests/TestWebSocket.ts
@@ -234,6 +234,9 @@ export class TestMessageEvent implements MessageEvent {
     constructor(data: any) {
         this.data = data;
     }
+    initMessageEvent(type: string, bubbles?: boolean | undefined, cancelable?: boolean | undefined, data?: any, origin?: string | undefined, lastEventId?: string | undefined, source?: MessageEventSource | null | undefined, ports?: MessagePort[] | undefined): void {
+        throw new Error("Method not implemented.");
+    }
     public data: any;
     public lastEventId: string = "";
     public origin: string = "";
diff --git a/src/SignalR/clients/ts/signalr/tests/Utils.ts b/src/SignalR/clients/ts/signalr/tests/Utils.ts
@@ -47,7 +47,7 @@ export class PromiseSource<T = void> implements Promise<T> {
         });
     }
 
-    public [Symbol.toStringTag]: string;
+    public [Symbol.toStringTag]: string = "";
 
     // @ts-ignore: onfinally not used
     public finally(onfinally?: (() => void) | null): Promise<T> {

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ export class HttpConnection implements IConnection {`
`434`	`434`	`return this.transport!.connect(url, transferFormat);`
`435`	`435`	`}`
`436`	`436`
`437`		`- private _resolveTransportOrError(endpoint: IAvailableTransport, requestedTransport: HttpTransportType \| undefined, requestedTransferFormat: TransferFormat): ITransport \| Error {`
	`437`	`+ private _resolveTransportOrError(endpoint: IAvailableTransport, requestedTransport: HttpTransportType \| undefined, requestedTransferFormat: TransferFormat): ITransport \| Error \| unknown {`
`438`	`438`	`const transport = HttpTransportType[endpoint.transport];`
`439`	`439`	`if (transport === null \|\| transport === undefined) {`
`440`	`440`	this._logger.log(LogLevel.Debug, `Skipping transport '${endpoint.transport}' because it is not supported by this client.`);
Original file line number	Diff line number	Diff line change
`@@ -862,7 +862,7 @@ export class HubConnection {`
`862`	`862`	`return;`
`863`	`863`	`}`
`864`	`864`
`865`		`- retryError = e instanceof Error ? e : new Error(e.toString());`
	`865`	`+ retryError = e instanceof Error ? e : new Error((e as any).toString());`
`866`	`866`	`nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts++, Date.now() - reconnectStartTime, retryError);`
`867`	`867`	`}`
`868`	`868`	`}`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ export class WebSocketTransport implements ITransport {`
`159`	`159`	`return Promise.resolve();`
`160`	`160`	`}`
`161`	`161`
`162`		`- private _close(event?: CloseEvent \| Error): void {`
	`162`	`+ private _close(event?: CloseEvent \| Error \| unknown): void {`
`163`	`163`	`// webSocket will be null if the transport did not start successfully`
`164`	`164`	`if (this._webSocket) {`
`165`	`165`	`// Clear websocket handlers because we are considering the socket closed now`
Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ describe("HttpConnection", () => {`
`483`	`483`	`await connection.start(TransferFormat.Text);`
`484`	`484`	`fail("Expected connection.start to throw!");`
`485`	`485`	`} catch (e) {`
`486`		- expect(e.message).toBe(`Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);
	`486`	+ expect((e as any).message).toBe(`Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);
`487`	`487`	`}`
`488`	`488`	`},`
`489`	`489`	`Failed to start the connection: Error: Unable to connect to the server with any of the available transports. ${HttpTransportType[requestedTransport]} failed: Error: '${HttpTransportType[requestedTransport]}' is disabled by the client.`);