Skip to content

Commit 8bf447a

Browse files
authored
update contributing guidelines to state that Squash is preferred (dotnet#44475)
I understand from @captainsafia that this is de-facto policy. BTW, we may want to require admin elevation for merge and rebase into main. dotnet/runtime does this and it has caused little or no trouble.
1 parent 678a06f commit 8bf447a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

CONTRIBUTING.md

+6
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ If you don't know what a pull request is read this article: <https://help.github
106106

107107
Your pull request will now go through extensive checks by the subject matter experts on our team. Please be patient; we have hundreds of pull requests across all of our repositories. Update your pull request according to feedback until it is approved by one of the ASP.NET team members. After that, one of our team members may adjust the branch you merge into based on the expected release schedule.
108108

109+
## Merging pull requests
110+
111+
When your pull request has had all feedback addressed, it has been signed off by one or more reviewers with commit access, and all checks are green, we will commit it.
112+
113+
We commit pull requests as a single Squash commit unless there are special circumstances. This creates a simpler history than a Merge or Rebase commit. "Special circumstances" are rare, and typically mean that there are a series of cleanly separated changes that will be too hard to understand if squashed together, or for some reason we want to preserve the ability to bisect them.
114+
109115
## Code of conduct
110116

111117
See [CODE-OF-CONDUCT.md](./CODE-OF-CONDUCT.md)

0 commit comments

Comments
 (0)