Merge pull request #333 from Enmk/set-backward_compatibility_lowcardinality_as_wrapped_column-deafult_value_to_false

Set backward_compatibility_lowcardinality_as_wrapped_column default value to false

Author: Enmk

clickhouse/client.h

@@ -123,7 +123,7 @@ struct ClientOptions {
     * @see LowCardinalitySerializationAdaptor, CreateColumnByType
     */
     [[deprecated("Makes implementation of LC(X) harder and code uglier. Will be removed in next major release (3.0) ")]]
-    DECLARE_FIELD(backward_compatibility_lowcardinality_as_wrapped_column, bool, SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn, true);
+    DECLARE_FIELD(backward_compatibility_lowcardinality_as_wrapped_column, bool, SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn, false);
 
     /** Set max size data to compress if compression enabled.
      *

ut/low_cardinality_nullable_tests.cpp

@@ -122,8 +122,8 @@ TEST(LowCardinalityOfNullable, InsertAndQueryEmpty) {
     block.AppendColumn("words", column);
 
     Client client(ClientOptions(localHostEndpoint)
-                      .SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(false)
-                      .SetPingBeforeQuery(true));
+            .SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(false)
+            .SetPingBeforeQuery(true));
 
     createTable(client);
 
@@ -141,7 +141,8 @@ TEST(LowCardinalityOfNullable, ThrowOnBackwardsCompatibleLCColumn) {
     block.AppendColumn("words", column);
 
     Client client(ClientOptions(localHostEndpoint)
-                      .SetPingBeforeQuery(true));
+            .SetPingBeforeQuery(true)
+            .SetBakcwardCompatibilityFeatureLowCardinalityAsWrappedColumn(true));
 
     createTable(client);