Skip to content

Commit 7d83db4

Browse files
committed
Attempt to fix test on Windows and MacOS
1 parent 27039a7 commit 7d83db4

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

ut/Column_ut.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -368,18 +368,20 @@ TYPED_TEST(GenericColumnTest, LoadAndSave) {
368368
auto [column_A, values] = this->MakeColumnWithValues(100);
369369

370370
// large buffer since we have pretty big values for String column
371-
char buffer[1024*1024] = {'\0'};
371+
auto const BufferSize = 10*1024*1024;
372+
std::unique_ptr<char[]> buffer = std::make_unique<char[]>(BufferSize);
373+
memset(buffer.get(), 0, BufferSize);
372374
{
373-
ArrayOutput output(buffer, sizeof(buffer));
375+
ArrayOutput output(buffer.get(), BufferSize);
374376
// Save
375-
EXPECT_NO_THROW(column_A->Save(&output));
377+
ASSERT_NO_THROW(column_A->Save(&output));
376378
}
377379

378380
auto column_B = this->MakeColumn();
379381
{
380-
ArrayInput input(buffer, sizeof(buffer));
382+
ArrayInput input(buffer.get(), BufferSize);
381383
// Load
382-
EXPECT_TRUE(column_B->Load(&input, values.size()));
384+
ASSERT_TRUE(column_B->Load(&input, values.size()));
383385
}
384386

385387
EXPECT_TRUE(CompareRecursive(*column_A, *column_B));
@@ -430,7 +432,7 @@ TYPED_TEST(GenericColumnTest, NullableT_RoundTrip) {
430432
TYPED_TEST(GenericColumnTest, ArrayT_RoundTrip) {
431433
using ColumnArrayType = ColumnArrayT<typename TestFixture::ColumnType>;
432434

433-
auto [nested_column, values] = this->MakeColumnWithValues(1000);
435+
auto [nested_column, values] = this->MakeColumnWithValues(100);
434436

435437
auto column = std::make_shared<ColumnArrayType>(nested_column->CloneEmpty()->template As<typename TestFixture::ColumnType>());
436438
for (size_t i = 0; i < values.size(); ++i)

0 commit comments

Comments
 (0)