Skip to content

Commit 3682e35

Browse files
committed
Minor: added comment and remove duplicate source from CMakeLists.txt
1 parent e712056 commit 3682e35

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

clickhouse/columns/lowcardinality.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,11 @@ void ColumnLowCardinality::Swap(Column& other) {
312312
if (!dictionary_column_->Type()->IsEqual(col.dictionary_column_->Type()))
313313
throw std::runtime_error("Can't swap() LowCardinality columns of different types.");
314314

315+
// It is important here not to swap pointers to dictionary object,
316+
// but swap contents of dictionaries, so the object inside shared_ptr stays the same
317+
// (needed for ColumnLowCardinalityT)
315318
dictionary_column_->Swap(*col.dictionary_column_);
319+
316320
index_column_.swap(col.index_column_);
317321
unique_items_map_.swap(col.unique_items_map_);
318322
}

ut/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ ADD_EXECUTABLE (clickhouse-cpp-ut
77
stream_ut.cpp
88
type_parser_ut.cpp
99
types_ut.cpp
10-
types_ut.cpp
1110

1211
performance_tests.cpp
1312
tcp_server.cpp

0 commit comments

Comments
 (0)