Merge pull request #254 from ClibMouse/bug_fix_2425

SadiHassan · web-flow · commit fc581bc07a2a · 2023-03-13T14:12:55.000-03:00
bug fix 2425
diff --git a/src/Parsers/Kusto/KustoFunctions/KQLGeneralFunctions.cpp b/src/Parsers/Kusto/KustoFunctions/KQLGeneralFunctions.cpp
@@ -50,6 +50,8 @@ bool Lookup::convertImpl(String & out, IParser::Pos & pos)
     {
         arg = getConvertedArgument(fn_name, temp_pos);
         ++num_of_args;
+        if (temp_pos->type == TokenType::ClosingRoundBracket)
+            break;
         ++temp_pos;
     }
     if (num_of_args == 3)
diff --git a/tests/queries/0_stateless/02366_kql_func_general.reference b/tests/queries/0_stateless/02366_kql_func_general.reference
@@ -34,3 +34,6 @@ Angel	Stewart	Professional	Partial College	46	bigger
 -- lookup
 First
 default
+10	First	1
+11	First	2
+12	First	3
diff --git a/tests/queries/0_stateless/02366_kql_func_general.sql b/tests/queries/0_stateless/02366_kql_func_general.sql
@@ -46,3 +46,4 @@ Customers | extend t = iif(Age <= 10, "smaller", "bigger");
 print '-- lookup';
 print lookup('dictionary_table', 'value', '1');
 print lookup('dictionary_table', 'value', '100', 'default');
+dictionary_source_table | project start_range, t = lookup('dictionary_table', 'value', '1'), key

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ bool Lookup::convertImpl(String & out, IParser::Pos & pos)`
`50`	`50`	`{`
`51`	`51`	`arg = getConvertedArgument(fn_name, temp_pos);`
`52`	`52`	`++num_of_args;`
	`53`	`+ if (temp_pos->type == TokenType::ClosingRoundBracket)`
	`54`	`+ break;`
`53`	`55`	`++temp_pos;`
`54`	`56`	`}`
`55`	`57`	`if (num_of_args == 3)`