Remove radiative_energy_toa

`radiative_energy_toa` is a field fully owned by atmos. There is no
reason for ClimaCoupler to maintain a copy. Instead, we can directly
access the value from atmos if we need it (it's only needed for
conservation checks).

Author: Sbozzolo

experiments/ClimaEarth/run_cloudless_aquaplanet.jl

@@ -202,7 +202,6 @@ coupler_field_names = [
     :F_radiative,
     :P_liq,
     :P_snow,
-    :radiative_energy_flux_toa,
     :P_net,
     :temp1,
     :temp2,

experiments/ClimaEarth/run_cloudy_aquaplanet.jl

@@ -221,7 +221,6 @@ coupler_field_names = [
     :F_radiative,
     :P_liq,
     :P_snow,
-    :radiative_energy_flux_toa,
     :P_net,
     :temp1,
     :temp2,

experiments/ClimaEarth/run_cloudy_slabplanet.jl

@@ -262,7 +262,6 @@ coupler_field_names = [
     :F_radiative,
     :P_liq,
     :P_snow,
-    :radiative_energy_flux_toa,
     :P_net,
     :temp1,
     :temp2,

experiments/ClimaEarth/run_dry_held_suarez.jl

@@ -172,7 +172,6 @@ coupler_field_names = [
     :F_radiative,
     :P_liq,
     :P_snow,
-    :radiative_energy_flux_toa,
     :P_net,
     :temp1,
     :temp2,

experiments/ClimaEarth/run_moist_held_suarez.jl

@@ -208,7 +208,6 @@ coupler_field_names = [
     :F_radiative,
     :P_liq,
     :P_snow,
-    :radiative_energy_flux_toa,
     :P_net,
     :temp1,
     :temp2,

experiments/ClimaEarth/setup_run.jl

@@ -425,7 +425,7 @@ function CoupledSimulation(config_dict::AbstractDict)
         Interfacer.add_coupler_fields!(coupler_field_names, sim)
     end
     # add coupler fields required to track conservation, if specified
-    energy_check && push!(coupler_field_names, :radiative_energy_flux_toa, :P_net)
+    energy_check && push!(coupler_field_names, :P_net)
 
     # allocate space for the coupler fields
     coupler_fields = Interfacer.init_coupler_fields(FT, coupler_field_names, boundary_space)

experiments/ClimaEarth/test/debug_plots_tests.jl

@@ -35,7 +35,7 @@ plot_field_names(sim::Interfacer.SurfaceStub) = (:stub_field,)
 @testset "import_atmos_fields!" begin
 
     boundary_space = TestHelper.create_space(FT)
-    coupler_names = [
+    coupler_names = (
         :surface_direct_albedo,
         :surface_diffuse_albedo,
         :F_radiative,
@@ -51,8 +51,7 @@ plot_field_names(sim::Interfacer.SurfaceStub) = (:stub_field,)
         :beta,
         :z0b_sfc,
         :z0m_sfc,
-        :radiative_energy_flux_toa,
-    ]
+    )
     atmos_names = (:atmos_field,)
     surface_names = (:surface_field,)
     stub_names = (:stub_field,)

experiments/ClimaEarth/user_io/debug_plots.jl

@@ -102,7 +102,7 @@ Plot useful coupler fields (in `field_names`) and save plots to a directory.
 If `cs_fields_ref` is provided (e.g., using a copy of cs.fields from the initialization),
 plot the anomalies of the fields with respect to `cs_fields_ref`.
 """
-function debug(cs_fields::CC.Fields.Field, dir, cs_fields_ref = nothing)
+function debug(cs_fields::NamedTuple, dir, cs_fields_ref = nothing)
     field_names = propertynames(cs_fields)
     fig = Makie.Figure(size = (1500, 800))
     min_square_len = ceil(Int, sqrt(length(field_names)))

src/ConservationChecker.jl

@@ -83,9 +83,7 @@ function check_conservation!(
     for sim in model_sims
         sim_name = Symbol(Interfacer.name(sim))
         if sim isa Interfacer.AtmosModelSimulation
-            radiative_energy_flux_toa = coupler_sim.fields.radiative_energy_flux_toa
-            # save radiation source
-            parent(radiative_energy_flux_toa) .= parent(Interfacer.get_field(sim, Val(:radiative_energy_flux_toa)))
+            radiative_energy_flux_toa = Interfacer.get_field(sim, Val(:radiative_energy_flux_toa))
 
             if isempty(ccs.toa_net_source)
                 radiation_sources_accum = sum(radiative_energy_flux_toa .* FT(float(coupler_sim.Δt_cpl))) # ∫ J / m^2 dA

src/Interfacer.jl

@@ -189,7 +189,6 @@ get_field(
         Val{:height_sfc},
         Val{:liquid_precipitation},
         Val{:radiative_energy_flux_sfc},
-        Val{:radiative_energy_flux_toa},
         Val{:snow_precipitation},
         Val{:turblent_energy_flux},
         Val{:turbulent_moisture_flux},

test/conservation_checker_tests.jl

@@ -58,13 +58,11 @@ for FT in (Float32, Float64)
 
         # coupler fields
         cf = (;
-            radiative_energy_flux_toa = CC.Fields.ones(space),
             P_net = CC.Fields.zeros(space),
             P_liq = CC.Fields.zeros(space),
             P_snow = CC.Fields.zeros(space),
             F_turb_moisture = CC.Fields.zeros(space),
         )
-        @. cf.radiative_energy_flux_toa = 200
         @. cf.P_liq = -100
 
         # init
@@ -86,7 +84,7 @@ for FT in (Float32, Float64)
         )
 
         # set non-zero radiation and precipitation
-        F_r = cf.radiative_energy_flux_toa
+        F_r = 200 .* CC.Fields.ones(space)
         P = cf.P_liq
         Δt = float(cs.Δt_cpl)
 
@@ -138,13 +136,11 @@ for FT in (Float32, Float64)
 
         # coupler fields
         cf = (;
-            radiative_energy_flux_toa = CC.Fields.ones(space),
             P_net = CC.Fields.zeros(space),
             P_liq = CC.Fields.zeros(space),
             P_snow = CC.Fields.zeros(space),
             F_turb_moisture = CC.Fields.zeros(space),
         )
-        @. cf.radiative_energy_flux_toa = 200
         @. cf.P_liq = -100
 
         # init