Add noImplicitOverride

`noImplicitOverride` guarantees type safety when overriding a class method. This also improves refactoring behavior.

The primary motivation for `noImplicitOverride` is for using with Lit elements where overriding methods is important.

Bug: 1402569
Change-Id: Ia095c38a6d1fc160f9b08c350d6f7248daab38a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4443322
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Randolf Jung <[email protected]>

Author: jrandolf-2

config/typescript/tsconfig.base.json

@@ -10,6 +10,7 @@
     "strict": true,
     "forceConsistentCasingInFileNames": true,
     "noImplicitReturns": true,
+    "noImplicitOverride": true,
     "noFallthroughCasesInSwitch": true,
     "useUnknownInCatchVariables": false,
 

front_end/core/common/Settings.ts

@@ -538,7 +538,7 @@ export class RegExpSetting extends Setting<any> {
     this.#regexFlags = regexFlags;
   }
 
-  get(): string {
+  override get(): string {
     const result = [];
     const items = this.getAsArray();
     for (let i = 0; i < items.length; ++i) {
@@ -554,7 +554,7 @@ export class RegExpSetting extends Setting<any> {
     return super.get();
   }
 
-  set(value: string): void {
+  override set(value: string): void {
     this.setAsArray([{pattern: value, disabled: false}]);
   }
 

front_end/core/platform/UserVisibleError.ts

@@ -11,7 +11,7 @@ import {type LocalizedString} from './UIString.js';
  * localized on the way in.
  */
 export class UserVisibleError extends Error {
-  readonly message: LocalizedString;
+  override readonly message: LocalizedString;
 
   constructor(message: LocalizedString) {
     super(message);

front_end/core/sdk/AccessibilityModel.ts

@@ -233,11 +233,11 @@ export class AccessibilityModel extends SDKModel<EventTypes> implements Protocol
     this.#frameIdToAXNode.clear();
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     await this.agent.invoke_enable();
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     await this.agent.invoke_disable();
   }
 

front_end/core/sdk/CPUProfileDataModel.ts

@@ -10,10 +10,10 @@ import {ProfileNode, ProfileTreeModel} from './ProfileTreeModel.js';
 import {type Target} from './Target.js';
 
 export class CPUProfileNode extends ProfileNode {
-  id: number;
-  self: number;
+  override id: number;
+  override self: number;
   positionTicks: Protocol.Profiler.PositionTickInfo[]|undefined;
-  deoptReason: string|null;
+  override deoptReason: string|null;
 
   constructor(node: Protocol.Profiler.ProfileNode, sampleTime: number, target: Target|null) {
     const callFrame = node.callFrame || ({

front_end/core/sdk/CSSModel.ts

@@ -727,14 +727,14 @@ export class CSSModel extends SDKModel<EventTypes> {
     this.#fontFaces.clear();
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     this.#isEnabled = false;
     await this.agent.invoke_disable();
     this.resetStyleSheets();
     this.resetFontFaces();
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     return this.enable();
   }
 
@@ -813,7 +813,7 @@ export class CSSModel extends SDKModel<EventTypes> {
     }
   }
 
-  dispose(): void {
+  override dispose(): void {
     this.disableCSSPropertyTracker();
     super.dispose();
     this.#sourceMapManager.dispose();

front_end/core/sdk/CSSRule.ts

@@ -190,7 +190,7 @@ export class CSSStyleRule extends CSSRule {
     return styleSheetHeader.columnNumberInSource(selector.range.startLine, selector.range.startColumn);
   }
 
-  rebase(edit: Edit): void {
+  override rebase(edit: Edit): void {
     if (this.styleSheetId !== edit.styleSheetId) {
       return;
     }
@@ -243,7 +243,7 @@ export class CSSKeyframeRule extends CSSRule {
     this.#keyText = new CSSValue(payload);
   }
 
-  rebase(edit: Edit): void {
+  override rebase(edit: Edit): void {
     if (this.styleSheetId !== edit.styleSheetId || !this.#keyText.range) {
       return;
     }

front_end/core/sdk/ChildTargetManager.ts

@@ -59,15 +59,15 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
     return Array.from(this.#childTargetsBySessionId.values());
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     await this.#targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: false, flatten: true});
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     await this.#targetAgent.invoke_setAutoAttach({autoAttach: true, waitForDebuggerOnStart: true, flatten: true});
   }
 
-  dispose(): void {
+  override dispose(): void {
     for (const sessionId of this.#childTargetsBySessionId.keys()) {
       this.detachedFromTarget({sessionId, targetId: undefined});
     }

front_end/core/sdk/DOMDebuggerModel.ts

@@ -261,11 +261,11 @@ export class DOMDebuggerModel extends SDKModel<EventTypes> {
     return this.#runtimeModelInternal;
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     this.suspended = true;
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     this.suspended = false;
   }
 
@@ -720,7 +720,7 @@ export class DOMEventListenerBreakpoint extends CategorizedBreakpoint {
     this.eventTargetNames = eventTargetNames;
   }
 
-  setEnabled(enabled: boolean): void {
+  override setEnabled(enabled: boolean): void {
     if (this.enabled() === enabled) {
       return;
     }

front_end/core/sdk/DOMModel.ts

@@ -1536,15 +1536,15 @@ export class DOMModel extends SDKModel<EventTypes> {
     return object.isNode() && object.objectId ? this.pushNodeToFrontend(object.objectId) : Promise.resolve(null);
   }
 
-  suspendModel(): Promise<void> {
+  override suspendModel(): Promise<void> {
     return this.agent.invoke_disable().then(() => this.setDocument(null));
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     await this.agent.invoke_enable({});
   }
 
-  dispose(): void {
+  override dispose(): void {
     DOMModelUndoStack.instance().dispose(this);
   }
 

front_end/core/sdk/DebuggerModel.ts

@@ -886,7 +886,7 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     return !error;
   }
 
-  dispose(): void {
+  override dispose(): void {
     this.#sourceMapManagerInternal.dispose();
     if (this.#debuggerId) {
       _debuggerIdToModel.delete(this.#debuggerId);
@@ -902,11 +902,11 @@ export class DebuggerModel extends SDKModel<EventTypes> {
         .removeChangeListener(this.asyncStackTracesStateChanged, this);
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     await this.disableDebugger();
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     await this.enableDebugger();
   }
 
@@ -1128,7 +1128,7 @@ export class BreakLocation extends Location {
     }
   }
 
-  static fromPayload(debuggerModel: DebuggerModel, payload: Protocol.Debugger.BreakLocation): BreakLocation {
+  static override fromPayload(debuggerModel: DebuggerModel, payload: Protocol.Debugger.BreakLocation): BreakLocation {
     return new BreakLocation(debuggerModel, payload.scriptId, payload.lineNumber, payload.columnNumber, payload.type);
   }
 }

front_end/core/sdk/EventBreakpointsModel.ts

@@ -88,7 +88,7 @@ class EventListenerBreakpoint extends CategorizedBreakpoint {
     this.instrumentationName = instrumentationName;
   }
 
-  setEnabled(enabled: boolean): void {
+  override setEnabled(enabled: boolean): void {
     if (this.enabled() === enabled) {
       return;
     }

front_end/core/sdk/IssuesModel.ts

@@ -38,7 +38,7 @@ export class IssuesModel extends SDKModel<EventTypes> implements ProtocolProxyAp
     this.dispatchEventToListeners(Events.IssueAdded, {issuesModel: this, inspectorIssue: issueAddedEvent.issue});
   }
 
-  dispose(): void {
+  override dispose(): void {
     super.dispose();
     this.#disposed = true;
   }

front_end/core/sdk/NetworkManager.ts

@@ -272,7 +272,7 @@ export class NetworkManager extends SDKModel<EventTypes> {
     void this.#networkAgent.invoke_setCacheDisabled({cacheDisabled: enabled});
   }
 
-  dispose(): void {
+  override dispose(): void {
     Common.Settings.Settings.instance()
         .moduleSetting('cacheDisabled')
         .removeChangeListener(this.cacheDisabledSettingChanged, this);

front_end/core/sdk/OverlayModel.ts

@@ -224,12 +224,12 @@ export class OverlayModel extends SDKModel<EventTypes> implements ProtocolProxyA
     await this.overlayAgent.invoke_setShowViewportSizeOnResize({show: this.#showViewportSizeOnResize});
   }
 
-  async suspendModel(): Promise<void> {
+  override async suspendModel(): Promise<void> {
     Common.EventTarget.removeEventListeners(this.#registeredListeners);
     await this.overlayAgent.invoke_disable();
   }
 
-  async resumeModel(): Promise<void> {
+  override async resumeModel(): Promise<void> {
     await Promise.all([this.overlayAgent.invoke_enable(), this.wireAgentToSettings()]);
   }
 

front_end/core/sdk/PreloadingModel.ts

@@ -51,7 +51,7 @@ export class PreloadingModel extends SDKModel<EventTypes> {
         ResourceTreeModel, ResourceTreeModelEvents.PrimaryPageChanged, this.onPrimaryPageChanged, this);
   }
 
-  dispose(): void {
+  override dispose(): void {
     super.dispose();
 
     TargetManager.instance().removeModelListener(